search

tzapu / WiFiManager

ESP8266 WiFi Connection manager with web captive portal
http://tzapu.com/esp8266-wifi-connection-manager-library-arduino-ide/
MIT License
6.45k stars 1.94k forks source link

Limited redirect #1637

Open raomin opened 11 months ago

raomin commented 11 months ago

When I connect to wifimanager from my windows, it generates many requests (eg wpad/wpad.dat, autodiscover, etc.). All these requests end up being served by wifimanager twice: once for redirect and a second time as 404. It's often so consuming for asyncweb that the esp32 ends up crashing and my pc disconnected. It's often better from my mobile where I get less extra requests.

However, I believe we shouldn't redirect these extra requests in the first place. With this change, I see no more crashes nor disconnections.

raomin commented 11 months ago

Note: I took the list of redirection detection from here. I tested with windows, ios and android.

tablatronix commented 11 months ago

Yeah you are supposed to turn off all data when using captive portals but adding a filter is a good idea problem is keeping up with it there are no standards and they all randomly change

tablatronix commented 8 months ago

Add custom or callout for captive checking