search

tzapu / WiFiManager

ESP8266 WiFi Connection manager with web captive portal
http://tzapu.com/esp8266-wifi-connection-manager-library-arduino-ide/
MIT License
6.63k stars 1.98k forks source link

Removal of conditionals before every debug output #1750

Open khReichel opened 4 months ago

khReichel commented 4 months ago

Removal of redundant compiler conditionals before each debug output.

The conditionals remained at code positions that had further functionality in addition to the debug output

tablatronix commented 4 months ago

Why?

khReichel commented 4 months ago

Because there has been a ticket for that taks, right?

tablatronix commented 4 months ago

I tried testing this in the min size branch, and I could not confirm that the compiler was not still allocating flash strings.

khReichel commented 4 months ago

hmm.. I do not find any requirement about allocating flash strings in the ticket? see: https://github.com/tzapu/WiFiManager/issues/1570 So maybe we have to extend the ticket about that topic?