search

tzcoolman / FACS-OLD

0 stars 2 forks source link

kmer parameter in simple_remove and simple_check should not be editable #19

Open arvestad opened 11 years ago

arvestad commented 11 years ago

The k_mer parameter should be set from the actual bloom filter. As it stands right now, the coder sees a default value being set and it looks (to the user and coder) that it can be set on the command line. That option is a Bad Idea. Fortunately, whatever the user or coder decides is always overwritten by looking at the loaded bloom filter...

Please remove the command line option.

tzcoolman commented 11 years ago

Sure... In fact, the final parameter (like k_mer) will be loaded from bloom filter files, thus even a user type a new k_mer during decontamination, the number wont change. But I ll just remove it anymore in order to avoid misunderstanding for code readers