search

tzeumer / SIP2-Client-for-Python

MIT License
8 stars 11 forks source link

Logging problems #5

Open OrangeDog opened 6 years ago

OrangeDog commented 6 years ago

Two separate issues:

  1. Code will crash if SIP.log has not been set - should default to logging.getLogger(__name__)
  2. Uses print for logging - all output should go through the log at an appropriate level
tzeumer commented 6 years ago

I know the logging isn't good (it was even worse before), but I considered it as helpful enough. But as stated in the readme: "This was (nearly) my first go with Python." - so I'm well aware there is a lot room for improvement.

But I'm not anymore in Python now than I was back then. And I put this "project" on Github as a final step, but don't (in any foreseeable future) plan on putting any more work into it.

Still, I would most likely accept any pull request improving things. And everything is under MIT license, so you can do anything you like anyway. :)

Sorry, if this is a disappointing answer; but at least a reaction to the issue at all :)