The country codes in the CG database were not made to be displayed. Before storing country codes, we map some codes to other codes, for the purposes of computing country streaks. This means that some mappings are not very neutral/desirable for showing to users. Especially the fact that occupied Palestinian territories are counted as "IL" in streaks is not a big problem if it's internally in our database (the letters don't matter, what matters is they compare equal), but it is a big deal if shown to users.
This PR removes the country flag and code from !lastloc, and it renames relevant properties named .country to .streakCode to clarify what they are intended to represent.
The country codes in the CG database were not made to be displayed. Before storing country codes, we map some codes to other codes, for the purposes of computing country streaks. This means that some mappings are not very neutral/desirable for showing to users. Especially the fact that occupied Palestinian territories are counted as "IL" in streaks is not a big problem if it's internally in our database (the letters don't matter, what matters is they compare equal), but it is a big deal if shown to users.
This PR removes the country flag and code from
!lastloc, and it renames relevant properties named.countryto.streakCodeto clarify what they are intended to represent.