search

tzixi / pe

0 stars 0 forks source link

Incorrect constraint in UG #11

Open tzixi opened 1 year ago

tzixi commented 1 year ago

The 'should not contain only numeric characters' constraint does not apply to ingredients despite the it being stated in UG as user is able to input all numerical ingredients as shown in second image

image.png

image.png

nus-se-script commented 1 year ago

Team's Response

We are unable to reproduce the bug with the add command code only. Additionally, it is a FunctionalityBug as we forgot to implement the checker for the edit commands as well which may have led to this scenario raised by the tester. Also the steps to recreate the bug was also not provided and hence it is invalid.

photo_2023-04-17_09-51-48.jpg

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: These are the steps to reproduce it:

image.png

The explanation for the bug type being a documentation bug will be under the reason for the issue type.

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** This is a Documentation bug. In my previously submitted bug report (contrasting instructions for add #10), the team rejected it, referring to the examples given in the UG where the commas are used to separate the ingredients. I accepted their explanation as it was reasonable. ![image.png](https://raw.githubusercontent.com/tzixi/pe/main/files/7d2d01ab-d007-4fe7-84f4-3beb825fbbd7.png) However, this came with the implication that the INGREDIENTS parameter did **not** encompass the commas. As such, it is reasonable to assume that the ingredients inputted containing only numeric characters do not include the required commas separating them either. In this case, this is a documentation bug as there were wrong or unclear constraints given in the User Guide since fully numerical ingredients could still be added.