search

tzixi / pe

0 stars 0 forks source link

Duplicate recipes not handled #3

Open tzixi opened 1 year ago

tzixi commented 1 year ago

Exact same recipe can be added

image.png

nus-pe-script commented 1 year ago

Team's Response

This is a feature of the app and not a bug, working as intended. Please refer to the screenshot below. Thanks!

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate recipes not detected

If the user issues the same add command with the same recipe step twice, the app does not complain:

image.png

And successfully adds two identical recipes:

image.png

While the app doesn't need to block adding two duplicate recipes, it should at least warn the user since it might be a legitimate mistake. After all, it is unlikely for two distinct recipes in the real world to have identical steps, name and ingredients, so this is likely to be a mistake, and thus not warning the user makes the feature seem incomplete.

The severity is low though since users can simply delete the duplicate recipe, and having duplicate recipes does not impact using the rest of the app's features.

[original: nus-cs2113-AY2223S2/pe-interim#1018] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is a feature of the app and not a bug, working as intended. Please refer to the screenshot below. Thanks!

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I apologize for any ambiguity in my bug report. The recipes inputted are exactly the same. According to the screenshots that the team has kindly provided, the app only accepts the same name for **different recipes**.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** In a scenario where the user has forgotten whether or not they have inputted a certain dish, and wants to transfer the exact recipe into the application, they might find themselves having 2 of the exact same recipes with nothing to differentiate them. Nothing that will cause the user to have any issues with the application, but to some forgetful users, this may happen occasionally, which is considered a **Medium** severity. ![image.png](https://raw.githubusercontent.com/tzixi/pe/main/files/09eb8611-77e0-43ed-ae3d-499fe7b1c694.png)