search

tzlaine / parser

A C++ parser combinator library.
Boost Software License 1.0
69 stars 12 forks source link

WIN32: fix boost build b2.exe for non-msvc compilers #173

Open d5ch4k opened 2 months ago

d5ch4k commented 2 months ago

propagate the selected compiler from cmake down to the boost bootstrap process without these correction the boost bootstrap build of b2 will fail on windows with e.g. clang for clang 'if(MSVC)' is false and the build process assumes a unix style shell and the build process fails I'm using Clion (Jetbrains) IDE for Multiplatform development on macOS, Linux and Windows, which makes it very easy to switch between different compilers and test Code compatibility

tzlaine commented 1 month ago

This seems like a reasonable change, but it breaks the build.

codecov-commenter commented 1 month ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

d5ch4k commented 1 month ago

mmh, strange. I noticed, that the respective "Windows MSVC / build (23, windows-2022) (pull_request)" already failed on your last check-in (April 1) with exactly the same error (https://github.com/tzlaine/parser/actions/runs/8513670468/job/23317833028) and that fedora changed the GCC compiler from 13.0.2 (https://github.com/tzlaine/parser/actions/runs/8513670482/job/23317832249 , see configure section) to 14.0.1 (https://github.com/tzlaine/parser/actions/runs/8901839715/job/24588909706 , see configure section) I'll try to check if the baseline (i.e. the develop branch with only whitespace changes in CmakeList.txt) has no errors.

d5ch4k commented 1 month ago

I think issue #169 breaks the build for the respective os-compiler-c++ variant (see #174)