search

tzmfreedom / rustforce

Salesforce REST API Client by Rust
MIT License
41 stars 19 forks source link

implemented login using SOAP endpoint #17

Closed abusarah-tech closed 2 years ago

abusarah-tech commented 2 years ago

Hi,

I have extended client.rs further and used some utils methods and regex library to achieve it. I am pretty new to Rust so if I am doing something wrong in terms of coding convention or contribution guidelines, let me know.

abusarah-tech commented 2 years ago

Your are welcome. I just committed the last thing that should fix the building on the workflow. Thank you for allowing me to contribute on this project. I am still planning on extending this library as I will be using it on some of my projects.

EDIT: I appreciate your patience with this PR. I am quite sure the latest commit is going to make it pass.

abusarah-tech commented 2 years ago

Tests are crashing because of invalid_client_id. I am not sure if this has to do with my changes or the workflow needs to re-configured with a valid client id.

abusarah-tech commented 2 years ago

Hi, I wanted to check again if there is some progress on the MR or if there are anything I can help with to fix the CI issue.

tzmfreedom commented 2 years ago

Sorry for late reply. I'll check it.

tzmfreedom commented 2 years ago

@AbuHafsa I try fixing the CI issue, but I didn't resolve it. But I think the change from this pull request is correct, so I'll merge this pull request and release new version. After that, I'll check the CI issue again.

abusarah-tech commented 2 years ago

No problem. I am glad that the changes are fit for the project.