search

tzookb / tbmsg

107 stars 30 forks source link

Conversations pagination and missing title/subject #51

Open ghost opened 8 years ago

ghost commented 8 years ago

Maybe I have missed this. There is no way to paginate the conversations; supposing a user has 100 conversations it is not safe to return all conversations.

Conventionally messages/threads/conversations require a title. There is no field a conversation title in the conversations table.

ghost commented 8 years ago

I see the pagination issue has been touched in a previous thread. I have looked at the code. Isn't it much better to use Eloquent queries or query builder for Laravel in EloquentTBMsgRepository.php ? The Eloquent model already has a pagination system.

tzookb commented 8 years ago

Yes I know, for sure. I'm currently working on version 3, that will have pagination and conversation titles :)

It is quite close to finishing. Just need to add more stuff and clean.

You can check branch"v3"

ghost commented 8 years ago

Great! Thanks.

I will check it.