Closed cslotboom closed 4 years ago
cslotboom
commented
4 years ago It's subjective - I could imagine users using the readNodesandElements if they don't want to save all data.
However, because these are mostly used as internal commands, and because getNodesandElements() exists, I would support _readNodesandElements(ODBdir).
As are we officially denoting internal functions as '_internalfunction'?
u-anurag
commented
4 years ago Yes! All internal functions are named as _internalFunctions().
See "Naming Conventions" in https://openseespydoc.readthedocs.io/en/latest/src/Plotting_Development_Guide.html .
On Tue, Jun 23, 2020 at 3:30 PM cslotboom notifications@github.com wrote:
It's subjective - I could imagine users using the readNodesandElements if they don't want to save all data.
However, because these are mostly used as internal commands, and because getNodesandElements() exists, I would support _readNodesandElements(ODBdir).
As are we officially denoting internal functions as '_internalfunction'?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/u-anurag/OpenSeesPy/pull/20#issuecomment-648438398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQOUPUAN2SQ37WT4EHRRJLRYENF5ANCNFSM4OFIHHHQ .
Anurag Upadhyay Graduate Research Assistant, Civil and Environmental Engineering Department, University of Utah Salt Lake City, Utah, USA.
Ph. +1 7028327520
Email: iitg.anurag@gmail.com anurag.upadhyay@utah.edu
cslotboom
commented
4 years ago I've changed all instances of the _readNodesandElements and _saveNodesandElements to appropriately be internal functions.
I've added the readOBD function. I've also added a few tests that work with pytest, including a generic test for the readOBD function. I changed the "saveNodesandElements" and "readNodesandElements" to use a space instead of a comma as a delimiter.
The intention for this pull request is to be on u-anurag's plotting branch. If anyone else is seeing this then I have made a mistake...