u-blox / ubxlib

Portable C libraries which provide APIs to build applications with u-blox products and services. Delivered as add-on to existing microcontroller and RTOS SDKs.
Apache License 2.0
287 stars 82 forks source link

Option to Exclude Geofence #186

Closed FloriVeit closed 5 months ago

FloriVeit commented 5 months ago

Our project does not currently support C++, and it is not straightforward for us to add this support. We found that the Geofence feature specifically requires C++ support. Would it be possible to include an option in CMake to exclude the Geofence parts of ubxlib?

Additionally, we found that if we comment out line 143 in the ubxlib.cmake file, everything builds correctly. list(APPEND UBXLIB_SRC ${UBXLIB_BASE}/common/geofence/src/u_geofence_geodesic.cpp)

RobMeades commented 5 months ago

Ah, OK, let me find a way to do that...

RobMeades commented 5 months ago

I've updated the existing preview branch to include a potential fix: could you give it a spin?

FloriVeit commented 5 months ago

Thank you for the quick processing, the update works perfectly.

RobMeades commented 5 months ago

Good stuff, thanks for checking. I will update this issue when both changes land on master here and will delete the preview branch some time after that.

RobMeades commented 5 months ago

The fix is now pushed to master here in commit 4d076219927cf6f5ed3951542a6b0b24a3228592. Please let me know when you have moved there from the preview branch and I will delete it.

RobMeades commented 5 months ago

@FloriVeit: is it OK for me to delete https://github.com/u-blox/ubxlib/tree/preview_sock_sec_free_rmea now?

FloriVeit commented 5 months ago

Apologies, I forgot to respond earlier. Yes, you can delete this branch. I’ve tested the master, and it works perfectly for us.