u-fire / ESPHomeComponents

Components for Microfire sensors that can be used in ESPHome and Home Assistant.
7 stars 7 forks source link

Heltec v3 board #3

Open andykorol1 opened 3 months ago

andykorol1 commented 3 months ago

Hi, would it be possible to add support for the heltec v3 board. I understand it uses a sx1268 chip

justind000 commented 3 months ago

The component uses this library behind the scenes. It currently doesn't support the sx1268, although I did see it mentioned in a couple of issues.

The component itself makes thin use of the lora library. It is only used in a handful of places:

Lines 25-35 does setup Lines 86-88, 127-129, 169-171 does the sending

Another library could simply replace those.

andykorol1 commented 3 months ago

Thanks for the reply. I'm very new to modifying code and using other library's but I will have a look and see if I can copy and tweak it to suit my needs.

I'm not asking you to do the work but any advise or tips to help me would be great.

bvwelch commented 1 month ago

This bridge idea is great!

I have enjoyed using some of Sandeep's other libraries, but for Lora, I've used the Radiohead and the RadioLib libraries. Both worked well for me. I was wondering if you had considered either of them? This could provide support for many Lora boards and other radios as well.

Perhaps your concern is licensing. Sandeep has a nice MIT license. Some of your repos do not specify the license. Once you clarify your licensing, it may be possible to create forks that support these other libraries.

https://github.com/jgromes/RadioLib (MIT license) https://github.com/adafruit/RadioHead (gpl v3?) https://www.airspayce.com/mikem/arduino/RadioHead/

thank you for your work with espnow and lora.