u-ichi / fluent-plugin-mail

Fluentd output plugin to send mail
https://rubygems.org/gems/fluent-plugin-mail
Other
48 stars 20 forks source link

add debug mode to get more info why email send fail #11

Closed glaci-zz closed 9 years ago

glaci-zz commented 10 years ago

using this plugin with AWS SES, but getting no debug msg, finally i found that it is time out error by adding debug mode, hope this helps people out =)

sonots commented 9 years ago

Why don't you use log.debug?

glaci-zz commented 9 years ago

i dont think if i use log.debug and this pull request will pass lol

sonots commented 9 years ago

You mean it is okay to close? I don't understand what you mean well. Could you elaborate more?

sonots commented 9 years ago

Currently, fluentd support log_level option (of course, fluent-plugin-mail too), so log.debug will show up if users write fluent.conf like

<match **>
  type mail
  log_level debug
  ...
</match>

So, this is more proper way than introducing debug_mode because fluentd officially supports.

glaci-zz commented 9 years ago

ok , i will edit my code and send pull request again, anyway just want to help, cuz use this plugin but i dont know if my email sent success or not, thanks your advice =)

sonots commented 9 years ago

You may overwrite this pull req without sending another ;)

sonots commented 9 years ago

Oh, received another pull request https://github.com/u-ichi/fluent-plugin-mail/pull/15 just now, let me close this.