search

u-now / types-x

eXtend ServiceNow development with type definitions
MIT License
1 stars 3 forks source link

Rest remaining 2nd #69

Closed emyrold closed 5 years ago

emyrold commented 5 years ago

close #34 and #35

emyrold commented 5 years ago

Question: RESTAPIResponse . this line: setBody(body: any): void; . on the developer API site it says this should be an object, but instead of changing what was here I left it. Should I have changed any lines where the documentation says object to set the typescript explicitly object instead of leaving the 'any' value?

johncaruso commented 5 years ago

Leave it as any for now.

On Fri, Apr 12, 2019 at 9:12 AM emyrold notifications@github.com wrote:

Question: RESTAPIResponse . this line: setBody(body: any): void; . on the developer API site it says this should be an object, but instead of changing what was here I left it. Should I have changed any lines where the documentation says object to set the typescript explicitly object instead of leaving the 'any' value?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/u-now/types-x/pull/69#issuecomment-482569156, or mute the thread https://github.com/notifications/unsubscribe-auth/AANsjV6b5uWCKptSvndC-qyzwu5-PeJfks5vgIY2gaJpZM4csBWE .