Open JohnAZoidberg opened 3 years ago
Apparently one other duplication of the entries is because there's grub and isolinux configuration. Perhaps u-root should highlight where the entries were extracted from.
Maybe also make it possible to view the config (kernel, initrd, cmdline) of each option before executing it, to verify it's the right one. Currently, it seems, you have to tell by the name.
Does this relate to #2237 ?
Does this relate to #2237 ?
https://github.com/u-root/u-root/pull/2237 only focuses on improving GRUB BLSCFG support, the duplicate boot menu entries is still there.
Update: I initially thought there's a bug in u-root that duplicates the menu entries but it's actually the case that there are many submenus with the same entries but different grub parameters: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/installer/cd-dvd/iso-image.nix#L334 I'll try to understand how GRUB2 submenus work and how u-root might want to support them.
I attached the NixOS installation iso to QEMU and use the
boot
command to boot it. The generated boot menu shows some boot entries many times.I have the entries:
The following are added by u-root 10 times each:
but those two are added only once:
To Reproduce
where
nixos-21.05pre289339.83d907fd760-x86_64-linux.iso
is downloaded from https://channels.nixos.org/nixos-21.05/latest-nixos-minimal-x86_64-linux.isoinitramfs.linux_amd64.cpio
is built byu-root core boot
Expected behavior I expect each grub entry to show up in the u-root boot menu only once.
Additional context Add any other context about the problem here.