search

u-root / u-root

A fully Go userland with Linux bootloaders! u-root can create a one-binary root file system (initramfs) containing a busybox-like set of tools written in Go.
https://u-root.org
BSD 3-Clause "New" or "Revised" License
2.58k stars 399 forks source link

Add "PXE UROOT" to DHCPv6 vendor class #2079

Open rjoleary opened 3 years ago

rjoleary commented 3 years ago

Is your feature request related to a problem? Please describe. This is extra diagnosis information to compare u-root DHCP packets from standard DHCP packets. It is already this way for DHCPv4.

Describe the solution you'd like dhcpv6.WithOption(dhcpv6.ParseOptVendorClass([]byte("PXE UROOT")))

Describe alternatives you've considered We can also include BIOS version information from the SMBIOS tables. Perhaps append the env variable $UROOT_VENDOR_CLASS to "PXE_UROOT" so this is configurable.

hugelgupf commented 3 years ago

Don't use Parse. That is not a validly formated byte-vendor-opts either. It's missing the enterprise number.

Just create that object as &dhcpv6.OptVendorClass{EnterpriseNumber: N, Data: [][]byte{[]byte("PXE UROOT")}}

On Thu, Jul 29, 2021, 19:06 rjoleary @.***> wrote:

Is your feature request related to a problem? Please describe. This is extra diagnosis information to compare u-root DHCP packets from standard DHCP packets. It is already this way for DHCPv4.

Describe the solution you'd like dhcpv6.WithOption(dhcpv6.ParseOptVendorClass([]byte("PXE UROOT")))

Describe alternatives you've considered We can also include BIOS version information from the SMBIOS tables. Perhaps append the env variable $UROOT_VENDOR_CLASS to "PXE_UROOT" so this is configurable.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/u-root/u-root/issues/2079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPG3ET3VZ4KFUORDYYX6S3T2ICJXANCNFSM5BHTB2XQ .

rjoleary commented 3 years ago

What would be used as the enterprise number? Is there one already for LinuxBoot or Linux foundation?