u-wave / react-vimeo

Vimeo player component for React.
https://u-wave.net/react-vimeo
MIT License
216 stars 64 forks source link

Problems with onEnd, onPause, etc in strict mode #200

Open Feli02 opened 2 years ago

Feli02 commented 2 years ago

When I use any "on" event is not working the event, when I use the onEnd event, when the video finished no event is fire, same with other events such as pause. Everything else works fine, but those events are not working.

zotovy commented 2 years ago

same issue. Any updates?

Lexe003 commented 2 years ago

Ye, same issue here. If you found a workaround, please drop it here.

EDIT:

After some research found this:

https://github.com/cookpete/react-player/issues/1453#issuecomment-1126687518

Removing React.StrictMode solved the issue for me

goto-bus-stop commented 2 years ago

After some research found this: https://github.com/cookpete/react-player/issues/1453#issuecomment-1126687518 Removing React.StrictMode solved the issue for me

🤯

i am not sure when i can have a deeper look at this. The fact that StrictMode changes the behaviour suggests that it's to do with React double-mounting in development mode? it would be important to be compatible with this.

Takesizmail commented 1 year ago

+1

ayomikun-adenitire commented 5 months ago

Any updates on this issue? I’m still experiencing it.

aayodejii commented 3 months ago

I can also confirm this. Turning off strict mode helps.