u-wave / react-vimeo

Vimeo player component for React.
https://u-wave.net/react-vimeo
MIT License
217 stars 64 forks source link

Since version 0.9.6 react-vimeo breaks apps that use React 17 #201

Open RodrigoTomeES opened 2 years ago

RodrigoTomeES commented 2 years ago

Hi, when you use any version higher than 0.9.6 it produces the errors seen in the images. It seems that the library is no longer compatible with React 17.

imagen imagen

The problem is related with the dependecy -> @types/react@^17.0.0, when install react-vimeo 0.9.6 this install @types/react@^18.0.0 that breaks the app.

goto-bus-stop commented 2 years ago

it should accept both :/ https://github.com/u-wave/react-vimeo/blob/b96b482426073986fd44deacd9c196ef69e6252b/package.json#L36

the idea is to let your package manager decide the best fit, so if you have @types/react@17 in your tree, it should prefer to use that.

RodrigoTomeES commented 2 years ago

Hi, @goto-bus-stop

Mmm, I don't know, but when installing the latest version of react-vimeo, npm install @types/react@18 instead of @types/react@17 even though React 17 and @types/react@17 are defined in the project. I can make a video with the test

acomito commented 2 years ago

Running into a similar issue with the latest create-react-app and latest version of @u-wave/react-vimeo

johnafish commented 2 years ago

Had to manually downgrade @types/react to the 17.x version that we previously had installed. It seemed yarn adding this package automatically installed an 18.x version.

philohelp commented 2 years ago

Got that error too when yarn add a version > 0.9.5