search

u-wave / react-vimeo

Vimeo player component for React.
https://u-wave.net/react-vimeo
MIT License
210 stars 63 forks source link

onError doesnt work #55

Closed Leonhart08 closed 4 years ago

Leonhart08 commented 6 years ago

I tried to give a wrong Id and i get a 404 error, but i cant call the OnError props , it does nothing

¿What is the correct use of the OnError props?

gurnzbot commented 5 years ago

+1

goto-bus-stop commented 5 years ago

onError maps straight to the Vimeo Player API's 'error' event: https://github.com/vimeo/player.js#error

I don't know when it does and doesn't emit that. onError should be called on 404s and such i agree.

goto-bus-stop commented 4 years ago

Looks like an 'error' event is not emitted if the initial load fails. Fixing in #96

goto-bus-stop commented 4 years ago

:package: 0.8.2