Closed goto-bus-stop closed 7 years ago
i prefer the global JSON config object (eg. uWaveConfig
) injected into the HTML. that way we only have to recompile a very small part to change config—the HTML task usually takes like 10ms (it's just minifying a file), versus 20 seconds for a full optimised JavaScript build on SSD.
A full optimised CSS build also takes around 10 seconds, but i'm not sure if we can do much about that.
ideally, it would be great if the config did not need to be during build time, but at least it is configurable.
Yeah. we want to be able to run the client as static html/js files though, so we do need a way to do config during the build. We could of course have runtime config as well for people who use the Express middleware.
Config is now injected at runtime. Closing, build-time config will go to #240 instead.
hosts should be able to configure things on the client-side somehow. some ideas:
javascript:
css:
colours for example could be configurable. they should be passed both to JS (MuiTheme) & CSS (vars.css).
other stuff that should be configurable:
"We ♥ Kpop"
)without explicit server support (which we probably should not assume for things like colours) we're pretty much limited to configuring in the build step. that should be fine, though, probably.