Rename documented field lastmodified to last_modified as generated

u01jmg3 / ics-parser

Parser for iCalendar Events • PHP 8+, 7 (≥ 7.4), 5 (≥ 5.6)

MIT License

448 stars 144 forks source link

Rename documented field lastmodified to last_modified as generated #250

Closed frantzmiccoli closed 4 years ago

frantzmiccoli commented 4 years ago

I have added a test, not sure it is relevant though.

u01jmg3 commented 4 years ago

Thanks for the contribution.

What issue does this solve?

frantzmiccoli commented 4 years ago

The test is basically useless.

lastmodified was the declared field in the class (so in all autocompletion systems), but the parsed data is put in last_modified. It is just fixing this.

u01jmg3 commented 4 years ago

_but the parsed data is put in last_modified_

Sorry, whereabouts in the code?

frantzmiccoli commented 4 years ago

Around here: https://github.com/u01jmg3/ics-parser/pull/250/files#diff-cad15d971a6236da40446ed68aebcf31L126

u01jmg3 commented 4 years ago

Closing for now as this has not been reported by anyone else.

Happy to re-open if necessary.