Undiscoverable dtstart_tz and dtend_tz properties of Event class

u01jmg3 / ics-parser

Parser for iCalendar Events • PHP 8+, 7 (≥ 7.4), 5 (≥ 5.6)

MIT License

448 stars 144 forks source link

Undiscoverable dtstart_tz and dtend_tz properties of Event class #275

Closed coatesap closed 3 years ago

coatesap commented 3 years ago

At the moment, the dtstart_tz and dtend_tz properties of the ICal\Event class are not discoverable by static analysis tools as they are declared dynamically, and hence any access to them will appear as an error in an IDE.

Is there any reason why they can't be declared as permanent properties on the Event class, even if they are nullable?

I'm happy to open a PR for this if that seems reasonable?

u01jmg3 commented 3 years ago

It was added many years prior probably in an attempt to keep things clean and allow a simple isset() to be used.

Happy to accept a PR though