Closed s0600204 closed 3 years ago
- Do you know exactly what version of PHP 5.6.x would be needed?
I do not, although admittedly I haven't looked further than phpunit
's Packagist page (https://packagist.org/packages/phpunit/phpunit#5.7.27).
- Looks like I would have to release this as v3 of the parser
Understandable. Figured it was worth creating the PR just so that you were aware of the issue (and had a fix to hand).
The version used previously (
4.8.36
) was using the corephp
functioneach()
which was deprecated inphp 7.2
and removed forphp 8.0
. As such, developers running webservers withphp 8
were no longer able to run tests.As of this PR, we now rely on a slightly more recent version of
phpunit
(5.7.27
), which also requires us to bump our minimum supported version ofphp
to5.6
.Refs. https://www.php.net/manual/en/function.each
As an aside, it looks like
phpunit 6.0
requiresphp 7.0
as a minimum - and there's probably unlikely to ever be a newer version ofphpunit 5
- so this is most likely as far as we can go withphpunit
and still support some flavour ofphp 5
.