search

u2i / rspec-hive

Ruby Gem allowing unit testing Hive queries using RbHive and Hive running in a docker container.
MIT License
5 stars 1 forks source link

Add Gemfile.lock to .gitignore #35

Open lauratpa opened 6 years ago

lauratpa commented 6 years ago

So since one shouldn't check Gemfile.lock into source control for gems, maybe we should just go ahead and add it to .gitignore.

http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

When developing a gem, use the gemspec method in your Gemfile to avoid duplication. In general, a gem's Gemfile should contain the Rubygems source and a single gemspec line. Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem.

@madlew Since it seems to me that you care about good practices and want to tidy up this gem of ours, maybe you would like to have the honor;)

nowNick commented 6 years ago

@jekuta where do you find all these amazing articles?!

It makes perfect sense. @madlew if you have time - go ahead. If not I will be looking at this library anyway so I can take care of it :)

madlew commented 6 years ago

thanks @jekuta ! I'll do the honors ;)

madlew commented 6 years ago

@jekuta @nowNick @wmiel look at gitignore: https://github.com/u2i/rspec-hive/blob/master/.gitignore

the Gemfile.lock is already there but starts with a / as well as some other files, which I believe shouldn't start "/" - any ideas why it's that?