u3a-siteworks-development / u3a-siteworks-core

The core plugins
GNU General Public License v2.0
1 stars 0 forks source link

es_98 #103

Closed edwery closed 1 month ago

edwery commented 1 month ago

I think this covers the required changes.

There are other cases which I have ignored:

1) 'status' is used as a $_GET query parameter in class_u3a_admin - I think thats a correct use of the reserved word.

'cat' is used as a value of a query parameter in some places - but thats fine, its the name of the parameter which cannot be a reserved word.

This change will have backward compatibility issues for anyone who has created these lists already, either as a shortcode or generated using the editor and attributes. This is because the display parameters as grabbed from either $atts or $_GET, but use the same parameter names, so I could not change the $_GET parameter names without changing the javascript which reads the attributes too.

edwery commented 1 month ago

I confirmed that I could reproduce the problem with main, and not with es_98

edwery commented 1 month ago

I have added backwards compatibility so older blocks should still work if the newer parameter names are missing