u3d-community / U3D

Open-source, cross-platform 2D and 3D game engine built in C++
https://u3d.io
MIT License
187 stars 30 forks source link

Github workflow deletes home directory folders #26

Open SirNate0 opened 1 year ago

SirNate0 commented 1 year ago

I set up a self-hosted github actions runner on my mac. The "Scaffolding - cleanup" step of the macos.yml workflow deleted my projects folder on my mac.

      - name: Scaffolding - cleanup
        run: rm -rf ~/{.urho3d,projects}

This should not happen. Fortunately, I had nothing of importance in that folder, just a recently checked out copy of U3D with no important changes. But our workflow should not be creating/deleting these directories in the home folder. The directory should be chosen inside whatever "_work" directory the github runner uses, rather than in the home directory.

That, or we need to provide documentation warning of this possibility. Let's just say that if this had happened on my laptop instead of this new computer I would have been extremely unhappy.