u3d-community / U3D

Open-source, cross-platform 2D and 3D game engine built in C++
https://u3d.io
MIT License
191 stars 30 forks source link

Circular dependency in tolua++ bin #28

Open SirNate0 opened 1 year ago

SirNate0 commented 1 year ago

I may be misunderstanding something, but it seems to me that this produces an implicit circular dependency:

https://github.com/u3d-community/U3D/blob/eefc929633624a38840a421efa26347a80b967b3/Source/ThirdParty/toluapp/src/bin/CMakeLists.txt#L46-L62

The target is tolua++, which has a source file ${CMAKE_CURRENT_BINARY_DIR}/generated/toluabind.c, yet this file is the output of the custom command that uses tolua++ to produce the output (though CMake is not actually told that tolua++ is a dependency of the generated file).