search

u3d-community / U3D

Open-source, cross-platform 2D and 3D game engine built in C++
https://u3d.io
MIT License
160 stars 26 forks source link

Improve QA Workflow #44

Open SirNate0 opened 1 year ago

SirNate0 commented 1 year ago

I think there are several options to improve the QA workflow (which I'm pretty sure just fails each time at present).

  1. We can improve the .clang-format file to better reflect Urho's conventions, as well as update it for more modern clang-format (some of the parameters have changed, at least compared to version 14 I have on my laptop).
    • I suspect that at least one commit will need to be made that will apply many style changes throughout the code, but hopefully we can keep that "many" fairly small.
  2. We can actually have the QA run push a commit that applies the clang-format results to the code when we have PRs. This means developers do not have to install clang-format themselves, and keeps behavior consistent with the version of clang-format used by the Github Actions runner. The following actions seem to allow it, though there may be other better ones:
  3. We can enable clang-tidy linting, though I suspect that may also require some work to have it not needlessly flag lots of existing Urho code.