search

u3d-community / U3D

Open-source, cross-platform 2D and 3D game engine built in C++
https://u3d.io
MIT License
197 stars 32 forks source link

Samples use Contradictory Titles #57

Open SirNate0 opened 1 year ago

SirNate0 commented 1 year ago

The samples set two different window titles:

In Sample::Setup(): https://github.com/u3d-community/U3D/blob/011843ef9f1ea6216581aecd67b7370aab35c4f0/Source/Samples/Sample.inl#L60

In Sample::Start() (via Sample::SetWindowTitleAndIcon()) https://github.com/u3d-community/U3D/blob/011843ef9f1ea6216581aecd67b7370aab35c4f0/Source/Samples/Sample.inl#L199

Hardly a breaking issue, but one of them should be removed. I would prefer the second, but only because I use a sample as a base for my own projects, and I can overwrite the samples engineParameters_ in my own Setup() function.