42 check for completeness of a http request and parse accordingly

[u413-284-si]

Overview

1. Check for complete HTTP request in RequestParser class
2. Introduce enum ParsingStatus
3. Check against method if body detected
4. Check of request size against max body size (determined by ConfigFile) -> behaviour needs to be finished
5. Adapt test cases

re 1.

• Check for "\r\n\r\n": if not found, abort parsing
• After request line and headers are parsed, determine whether a body needs to be parsed
• If body indicated, check request string for completeness of body -> two cases: body size determined by Content-Length or end of chunked body signalled by zero chunk

re 2.

• ParsingStatus determines which parsing process shall be performed
• Repeated calls to parser will only trigger indicated parsing process when checks are passed
• Once parsing is completed, the according status triggers the response builder to act

re 3.

• If a body is indicated by according headers, it is verified that the method can actually have a method. If check failed, throws bad request exception

re 4.

• Check for too large request sizes and return according error to client
• Added status code 413 in enum and utility functions
• Need to decide whether to close connection in this case -> not specified by nginx

re 5.

• Test cases needed too be adapted to reflect new check for valid method <-> body combo
• Optimised test cases that expect a throw

closes #42

[u413-284-si]

Rework RequestParser

• Remove ParsingStatus enum
• split general parseHttpRequest method into parseHeader() and parseBody()
• add getters for m_hasBody and m_isChunked
• move check for CompleteBody into Server
• fix checks against Content-Length
• fix overwrite of Content-Length in case of a chunked Body

Rework Server

• adapt connectionReceiveHeader() to new parser methods
• add connectionReceiveBody()
• integrate check for complete Body
• check against clientMaxBodySize -> connectionReceiveBody() differs in this point from connectionReceiveHeader() which checks against the buffer size
• add status code 413: StatusRequestEntityTooLarge

Furthermore fix unit tests to work with new request parser methods.

[u413-284-si]

Had to move timestamp to function end again to account for the other cases when readFromSocket returns. Added timestamp to error cases just before the return statement.