u413-284-si / webserv

This project is about setting up a http web server, providing a static website.
MIT License
0 stars 0 forks source link

3 core socket programming #8

Closed u413-284-si closed 3 months ago

u413-284-si commented 3 months ago

Revision of core server:

  1. Removed attributes from Server class that were only used locally (nfds, clientSock)
  2. Removed checking of errno after read as it is forbidden by subject. Comes with loss of ability to handle other read errors than EWOULDBLOCK/EAGAIN. Opinions/suggestions on this matter requested.
  3. Established naming convention:
    • private attributes: start with underscore, eg. _serverSock
    • variables: start with lower case, any following word has first letter in upper Case
    • function names: start with verb, start with lower case, any following word has first letter in upper Case, eg. acceptConnection()
  4. Added Macro for BUFFER_SIZE of buffer for reading incoming data
  5. Added headlines/separators to structure the hpp/cpp files. We can vote on standardising this so that all our files have the same structure.
  6. Added doxygen and inline documentation

closes #3