search

u4819210 / social-networks-for-fun

Automatically exported from code.google.com/p/social-networks-for-fun
0 stars 0 forks source link

Issue: API /group/my-invitations, return result with different data format #41

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
If current user just has one invitation, the api returns a jsonObject. If user 
has more than one invitation, the api returns a jsonArray. It's better If the 
api always returns a jsonArray.

one invitation:
json = 
{"list":{"createTime":"2010-08-30T00:00:00+08:00","id":"8","invitee":{"banned":"
no","code":"","email":"guestsocialrays@yahoo.com","guid":"254","language":"zh","
lastAction":"1278290568","lastLogin":"1278290522","loginTime":"2010-06-28T16:14:
43+08:00","name":"Guest","password":"ee291b5e5ff415cf73fb65b80ccd5aba","password
Valid":"true","prevLastAction":"1278290567","prevLastLogin":"1278283986","salt":
"fb27be3e","userValid":"true","username":"guest123"},"inviter":{"banned":"no","c
ode":"3333","email":"59093558@qq.com","guid":"937","language":"en","lastAction":
"0","lastLogin":"0","loginTime":"2010-09-04T12:20:59+08:00","name":"xianhao","pa
ssword":"c27d52af8025e38e67d3efa157681cb5","passwordValid":"true","prevLastActio
n":"0","prevLastLogin":"0","salt":"b57d3ab4","userValid":"true","username":"xian
hao"},"joinGroup":{"closed":"false","description":"Xianhaogroup3","groupType":"P
RIVATE","guid":"49","name":"xianhaogroup3","owner":{"banned":"no","code":"3333",
"email":"59093558@qq.com","guid":"937","language":"en","lastAction":"0","lastLog
in":"0","loginTime":"2010-09-04T12:20:59+08:00","name":"xianhao","password":"c27
d52af8025e38e67d3efa157681cb5","passwordValid":"true","prevLastAction":"0","prev
LastLogin":"0","salt":"b57d3ab4","userValid":"true","username":"xianhao"},"siteI
d":"0","size":"0"}}}

More than one invitation:
json = 
{"list":[{"createTime":"2010-08-30T00:00:00+08:00","id":"8","invitee":{"banned":
"no","code":"","email":"guestsocialrays@yahoo.com","guid":"254","language":"zh",
"lastAction":"1278290568","lastLogin":"1278290522","loginTime":"2010-06-28T16:14
:43+08:00","name":"Guest","password":"ee291b5e5ff415cf73fb65b80ccd5aba","passwor
dValid":"true","prevLastAction":"1278290567","prevLastLogin":"1278283986","salt"
:"fb27be3e","userValid":"true","username":"guest123"},"inviter":{"banned":"no","
code":"3333","email":"59093558@qq.com","guid":"937","language":"en","lastAction"
:"0","lastLogin":"0","loginTime":"2010-09-04T12:20:59+08:00","name":"xianhao","p
assword":"c27d52af8025e38e67d3efa157681cb5","passwordValid":"true","prevLastActi
on":"0","prevLastLogin":"0","salt":"b57d3ab4","userValid":"true","username":"xia
nhao"},"joinGroup":{"closed":"false","description":"Xianhaogroup3","groupType":"
PRIVATE","guid":"49","name":"xianhaogroup3","owner":{"banned":"no","code":"3333"
,"email":"59093558@qq.com","guid":"937","language":"en","lastAction":"0","lastLo
gin":"0","loginTime":"2010-09-04T12:20:59+08:00","name":"xianhao","password":"c2
7d52af8025e38e67d3efa157681cb5","passwordValid":"true","prevLastAction":"0","pre
vLastLogin":"0","salt":"b57d3ab4","userValid":"true","username":"xianhao"},"site
Id":"0","size":"0"}},{"createTime":"2010-09-06T00:00:00+08:00","id":"21","invite
e":{"banned":"no","code":"","email":"guestsocialrays@yahoo.com","guid":"254","la
nguage":"zh","lastAction":"1278290568","lastLogin":"1278290522","loginTime":"201
0-06-28T16:14:43+08:00","name":"Guest","password":"ee291b5e5ff415cf73fb65b80ccd5
aba","passwordValid":"true","prevLastAction":"1278290567","prevLastLogin":"12782
83986","salt":"fb27be3e","userValid":"true","username":"guest123"},"inviter":{"b
anned":"no","code":"3333","email":"59093558@qq.com","guid":"937","language":"en"
,"lastAction":"0","lastLogin":"0","loginTime":"2010-09-04T12:20:59+08:00","name"
:"xianhao","password":"c27d52af8025e38e67d3efa157681cb5","passwordValid":"true",
"prevLastAction":"0","prevLastLogin":"0","salt":"b57d3ab4","userValid":"true","u
sername":"xianhao"},"joinGroup":{"closed":"false","description":"Xianhaogroup2",
"groupType":"PUBLIC","guid":"48","name":"xianhaogroup2","owner":{"banned":"no","
code":"3333","email":"59093558@qq.com","guid":"937","language":"en","lastAction"
:"0","lastLogin":"0","loginTime":"2010-09-04T12:20:59+08:00","name":"xianhao","p
assword":"c27d52af8025e38e67d3efa157681cb5","passwordValid":"true","prevLastActi
on":"0","prevLastLogin":"0","salt":"b57d3ab4","userValid":"true","username":"xia
nhao"},"siteId":"0","size":"0"}}]}

It's also better if we can simplify the returned result. It can save network 
traffic for smart phone. Some fields like language, banned, password, 
passwordValid, uservalid, prevLastAction etc is not used by the client side for 
invitation feature. 

Any idea?

Original issue reported on code.google.com by xianhao.lv@gmail.com on 6 Sep 2010 at 7:02

GoogleCodeExporter commented 8 years ago 
i fixed this single element json array issue few days ago. let me check if i 
missed any class.

Original comment by zhangyon...@gmail.com on 6 Sep 2010 at 2:10

GoogleCodeExporter commented 8 years ago 
LV, 

Could you please double check if you have the latest code? I did a test but 
could not reproduce this issue. Below is some test output from my unit test. It 
shows that the single invitation is in array format. 

Thanks,
Cheng

====================get my invitations
[DEBUG] header - >> "GET /prototype-socialrays-jersey/group/my-invitations 
HTTP/1.1[\r][\n]"
[DEBUG] header - >> "Accept: application/json[\r][\n]"
[DEBUG] header - >> "User-Agent: Jakarta Commons-HttpClient/3.1[\r][\n]"
[DEBUG] header - >> "Host: localhost:8517[\r][\n]"
[DEBUG] header - >> "Cookie: $Version=0; JSESSIONID=12we9x0z6vee; 
$Path=/prototype-socialrays-jersey[\r][\n]"
[DEBUG] header - >> "[\r][\n]"
[DEBUG] header - << "HTTP/1.1 200 OK[\r][\n]"
[DEBUG] header - << "HTTP/1.1 200 OK[\r][\n]"
[DEBUG] header - << "Content-Type: application/json[\r][\n]"
[DEBUG] header - << "Transfer-Encoding: chunked[\r][\n]"
[DEBUG] header - << "Server: Jetty(6.1.22)[\r][\n]"
[DEBUG] header - << "[\r][\n]"
[DEBUG] content - << "5"
[DEBUG] content - << "4"
[DEBUG] content - << "9"
[DEBUG] content - << "[\r]"
[DEBUG] content - << "[\n]"
[DEBUG] content - << 
"{"list":[{"createTime":"2010-09-06T07:07:55.480-07:00","id":"1","invitee":{"ban
ned":"no","code":"94040","email":"1283782075340210000","guid":"2","language":"en
","lastAction":"0","lastLogin":"0","loginTime":"2010-09-06T07:07:55.346-07:00","
name":"1283782075340210000","password":"deb641ce536ee63a0bc4e9a8799a6e82","passw
ordValid":"true","prevLastAction":"0","prevLastLogin":"0","salt":"2b62a2e4","use
rValid":"true","username":"1283782075340210000"},"inviter":{"banned":"no","code"
:"94040","email":"1283782075368342000","guid":"4","language":"en","lastAction":"
0","lastLogin":"0","loginTime":"2010-09-06T07:07:55.381-07:00","name":"128378207
5368342000","password":"df7b5126fb2e458e5627f5fbe8b99754","passwordValid":"true"
,"prevLastAction":"0","prevLastLogin":"0","salt":"609f237c","userValid":"true","
username":"1283782075368342000"},"joinGroup":{"closed":"false","groupType":"PRIV
ATE","guid":"2","name":"1283782075402826000","owner":{"banned":"no","code":"9404
0","email":"1283782075368342000","guid":"4","language":"en","lastAction":"0","la
stLogin":"0","loginTime":"2010-09-06T07:07:55.381-07:00","name":"128378207536834
2000","password":"df7b5126fb2e458e5627f5fbe8b99754","passwordValid":"true","prev
LastAction":"0","prevLastLogin":"0","salt":"609f237c","userValid":"true","userna
me":"1283782075368342000"},"siteId":"0","size":"0"},"status":"ACCEPTED"}]}"
[DEBUG] content - << "[\r]"
[DEBUG] content - << "[\n]"
[DEBUG] content - << "0"
[DEBUG] content - << "[\r]"
[DEBUG] content - << "[\n]"
[DEBUG] content - << "[\r]"
[DEBUG] content - << "[\n]"
[DEBUG] header - << "[\r][\n]"

Original comment by zhangyon...@gmail.com on 6 Sep 2010 at 2:20