search

u8sand / Baka-MPlayer

The libmpv based media player
https://u8sand.github.io/Baka-MPlayer/
GNU General Public License v2.0
433 stars 93 forks source link

Segfault in libmpv with some mp3 files #193

Closed elvisangelaccio closed 8 years ago

elvisangelaccio commented 8 years ago

I'm on Archlinux, baka v2.0.4 and mpv v0.15.0.

In the attached files you can find the backtrace from the coredump and the valgrind log. The crash seems to be in libmpv, so I installed debug symbols only for mpv. If you need debug symbols also for baka, let me know and I will install them.

baka-backtrace.txt baka-valgrind.txt

Chromace commented 8 years ago

Did those files have any embedded album art in them?

elvisangelaccio commented 8 years ago

@Chromace Nope. They are mp3 encoded (with lame) out of .wav voice recordings

Chromace commented 8 years ago

This is just a guess, but does playing them with embedded album art work properly? It might be related to my issue.

elvisangelaccio commented 8 years ago

@Chromace Can you suggest me an app to do so? I'm not familiar with mp3 embedding :)

Chromace commented 8 years ago

Kid3. That's what I use.

elvisangelaccio commented 8 years ago

@Chromace You're right! After embedding a picture in the mp3, Baka does not crash anymore!

Chromace commented 8 years ago

Looks like it's similar to my issue. ( #192)

Chromace commented 8 years ago

I'm going out on a limb but...do the audio files (without album art) make Baka crash, but work fine in mpv?

elvisangelaccio commented 8 years ago

@Chromace Yes, they can be played with mpv just fine.

godly-devotion commented 8 years ago

@aelog @Chromace After reading both your issues I believe it is the same issue as #181. This will hopefully be fixed when we switch over from mpv overlay based code to drawing text ourselves via QML. Personally speaking, I've been having this issue also regarding audio files causing Baka to crash on Windows 10 too.

Chromace commented 8 years ago

@godly-devotion What will mpv be responsible for after that?

godly-devotion commented 8 years ago

@Chromace mpv is still our main playback engine. We were using mpv's overlay system to show status and album art but that is currently causing issues so we will handle that part ourselves.

Chromace commented 8 years ago

@godly-devotion This might be a silly question after that, but does that mean mpv will still be responsible for displaying subtitles? Thanks.

godly-devotion commented 8 years ago

@Chromace Yes. Subtitles and overlay code are different.

u8sand commented 8 years ago

We'll just merge these two issues with #192