u8sand / Baka-MPlayer

The libmpv based media player
https://u8sand.github.io/Baka-MPlayer/
GNU General Public License v2.0
433 stars 93 forks source link

Split configuration file. One for the settings and one to keep track of recently played files. #202

Closed loathingKernel closed 10 months ago

loathingKernel commented 8 years ago

I like to keep my configuration files in sync between my computers and for that I am using git. Having recently played files in one configuration file made bakamplayer.ini to change every time I played a new file. This PR fixes that issue. In addition it creates a folder inside the configuration directory to keep both bakamplayer.ini and recent.json for less clutter.

For now I changed only the linux specific code. If you have any suggestions or issues with it, I am happy to fix it.

godly-devotion commented 8 years ago

@u8sand When you get a chance can you take a look?

u8sand commented 8 years ago

Thank you for your contribution.

Just to not leave this hanging. I have mixed feelings about this PR. Though it solves a solid issue, I'll want to further address other configuration file concerns before I change it in master (when people get the new version we want the config change to be seamless). Specifically mpv.conf concerns. I'm going to leave this here for now, when the time comes I'll definitely use and credit your changes.

loathingKernel commented 8 years ago

Thanks for taking a look at this. I get what you are saying, I noticed that the code is transitioning, you still have functions to load the old-style configuration file. My PR is crude to say the least, I know that, but since it is not an issue that is going to affect many, I decided to hack together a solution. A proper solution would require somewhat more effort, like importing the old .ini, so look at this mostly as an example or a starting point. Initially I wanted to just create an issue report but since the code-base is small and easily graspable, I just thought that contributing to the project in general would be better.

On the other hand, I am making a greek translation for baka, but that is subject for another PR.