search

u8sand / Baka-MPlayer

The libmpv based media player
https://u8sand.github.io/Baka-MPlayer/
GNU General Public License v2.0
428 stars 93 forks source link

fix crash on wayland #296

Closed matijaskala closed 2 years ago

matijaskala commented 3 years ago
u8sand commented 3 years ago

I'll check on this -- I wrote platform specific code because despite claiming to work in a cross platform way, the qt code did not when I tested last; but this was years ago so maybe!

Thanks for your PR will hopefully get to it soon.. Alternatively wayland could be an different platform target

matijaskala commented 3 years ago

I did read about some bugs related to always-on-top. They have been fixed with qt-5.4.

Anyway I found another wayland bug. This line seems to be causing it, but it is not trivial to replace it.

u8sand commented 3 years ago

In a stalled follow-up project i adopted mpv's newer interface which i believe has support for this and fixes a bunch of other bugs, but frankly revamping this project is really low on my life's todo list :/

On Fri, Nov 13, 2020, 4:51 AM Matija Skala notifications@github.com wrote:

I did read about some bugs related to always-on-top. They have been fixed with qt-5.4.

Anyway I found another wayland bug. This line https://github.com/u8sand/Baka-MPlayer/blob/master/src/mpvhandler.cpp#L30 seems to be causing it, but it is not trivial to replace it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/u8sand/Baka-MPlayer/pull/296#issuecomment-726665160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKHTJNTSESPSJ6VA6M6JQ3SPT6SJANCNFSM4TUAWZHQ .

matijaskala commented 3 years ago

I tried to implement proper wayland support but wasn't successful. The patch I just uploaded is sufficient to fix crashes, but doesn't fix other bugs.

u8sand commented 2 years ago

Well since I clearly don't have time for this it's about time I merged this. Thank you for your contribution.