u8sand / Baka-MPlayer

The libmpv based media player
https://u8sand.github.io/Baka-MPlayer/
GNU General Public License v2.0
433 stars 93 forks source link

Title progress indicator #307

Open ghost opened 3 years ago

ghost commented 3 years ago

The title progress indicator doesn't work under Manjaro Linux. No movement. A function "Open only one instance" would be desirable.

Regards waldy17

AnonumousMouse commented 3 years ago

Same issue of non-responsive progress bar. Dragging it to desired location restarts the playback and causes the progress bar to get stuck despite otherwise playing the file correctly. Tagging the maintainer ( @u8sand ) as I am necroing this issue thread.

Environment:

MPV Versioning:
$ mpv -v
[cplayer] Command line options: '-v'
[cplayer] mpv 0.33.1-dirty Copyright © 2000-2020 mpv/MPlayer/mplayer2 projects
[cplayer]  built on UNKNOWN
[cplayer] FFmpeg library versions:
[cplayer]    libavutil       56.70.100
[cplayer]    libavcodec      58.134.100
[cplayer]    libavformat     58.76.100
[cplayer]    libswscale      5.9.100
[cplayer]    libavfilter     7.110.100
[cplayer]    libswresample   3.9.100
[cplayer] FFmpeg version: n4.4
ScriptJunky commented 2 years ago

Can also confirm unresponsive progress bar is occurring on EndeavourOS (an Arch derivative), with a built from source binary;

Baka-Mplayer branch/commit info:

{20:59}~/git/Baka-MPlayer:release ✓ ➭ git status
On branch release
Your branch is up to date with 'origin/release'.

nothing to commit, working tree clean
{20:59}~/git/Baka-MPlayer:release ✓ ➭ git log --oneline | head -2
1911edc Fixes #177
e1df4b4 Simply use qCeil instead
{20:59}~/git/Baka-MPlayer:release ✓ ➭ 

OS: EndeavourOS Kernel: 5.16.2-arch1-1 DE: Cinnamon 5.2.7

ScriptJunky commented 2 years ago

OK an update, I reverted the change in this commit -- https://github.com/u8sand/Baka-MPlayer/commit/72325037151893f1ac17e0babae8826cd1382388 -- in my local copy of ./src/mpvhandler.cpp, recompiled, and the progress bar now operates as intended.

TL,DR;

change this --

    mpv_get_property(mpv, "length", MPV_FORMAT_DOUBLE, &len);

into this --

    mpv_get_property(mpv, "duration", MPV_FORMAT_DOUBLE, &len);

and voila! Working progress bar.

Screenshot from 2022-01-24 23-34-24