search

u8sand / Baka-MPlayer

The libmpv based media player
https://u8sand.github.io/Baka-MPlayer/
GNU General Public License v2.0
428 stars 93 forks source link

New Release #331

Open u8sand opened 1 year ago

u8sand commented 1 year ago

Some code refactoring and implemented the new mpv renderer API; this seems to fix wayland support, works better on linux mint mate, and presumably may also fix other things.

Hopefully I can get this compiled for Windows to make a release in the coming weeks. If anyone is interested in helping me test it let me know.

Fixes:

Possibly fixes:

If I can release it for windows and multiple distros it would likely address

TODO:

u8sand commented 1 year ago

Whoever is interested should please test them and let me know..

linux mint: baka-mplayer_2.1.0-1_amd64.deb.zip

windows 10 64bit: baka-mplayer-win64.7z.zip (please note, I used 7z followed by zip so it would be small enough to meet github's upload constraint of 25MB)

Zeirison commented 1 year ago

Whoever is interested should please test them and let me know..

linux mint: baka-mplayer_2.1.0-1_amd64.deb.zip

windows 10 64bit: baka-mplayer-win64.7z.zip (please note, I used 7z followed by zip so it would be small enough to meet github's upload constraint of 25MB)

I can try to build and test on a Mac M1, does that make sense?

u8sand commented 1 year ago

@Zeirison that'd be awesome; unfortunately I don't have access to a Mac to help with that directly but can try to help if you run into any issue you're unable to address.. My guess is you'd need to disable dim dialog like on Wayland. As long as mpv and qt are running on Mac it should be achievable.

Zeirison commented 1 year ago

Surprisingly, the player built and ran natively on arm64 without any problems at all, then I'll start testing it :)

image

image

To build and run, these commands are enough:

brew install youtube-dl
brew install mpv
git clone -b release https://github.com/u8sand/Baka-MPlayer.git
cd Baka-MPlayer
brew install qt@5
./configure CONFIG+=install_translations
make
open build
u8sand commented 1 year ago

@Zeirison thanks! that's pretty neat I didn't know the current one already works for Mac, in the past I think it built but then would segfault immediately, and that was on x86. Seems qt has likely hammered out the issues since then.

If possible please also see if the rc branch works (git checkout rc and rebuild) and if there is a noticable performance hit as reported by someone else. Maybe I just make which rendering api to use an option..

Zeirison commented 1 year ago

@Zeirison thanks! that's pretty neat I didn't know the current one already works for Mac, in the past I think it built but then would segfault immediately, and that was on x86. Seems qt has likely hammered out the issues since then.

If possible please also see if the rc branch works (git checkout rc and rebuild) and if there is a noticable performance hit as reported by someone else. Maybe I just make which rendering api to use an option..

Video playback in the master branch doesn’t work, so I used the rc branch. There are performance issues, they mostly appear when the video is playing, the window becomes very unresponsive and various artifacts appear. There are also several critical and minor bugs that make it quite difficult to use the app (I'll create separate issues for them and help with debugging and testing).

JXWw3wLD9LArcR7c commented 1 year ago

Whoever is interested should please test them and let me know..

linux mint: baka-mplayer_2.1.0-1_amd64.deb.zip

windows 10 64bit: baka-mplayer-win64.7z.zip (please note, I used 7z followed by zip so it would be small enough to meet github's upload constraint of 25MB)

I can confirm the subtitles issue https://github.com/u8sand/Baka-MPlayer/issues/262 https://github.com/u8sand/Baka-MPlayer/issues/325 should be fixed with this version on Windows 10 Home 22H2 64 bit. I'll try to binge some anime to see if I can find any issues that were not present before.

JXWw3wLD9LArcR7c commented 1 year ago

There's this bug on version 2.0.4 that's also fixed in this version. It probably has something to do with graphics cards and using two screens. Whenever you exit fullscreen, the video will be cropped until you press play, when you press play the video will readjust itself to the windows size. Another bug is the play bar appearing twice on fullscreen sometimes. That's also fixed. I was going to take a picture, but I had difficulty replicating it. Pretty sure a friend of mine also has this issue. image image

The screen flickering issue #288 is also fixed, but I am not sure since the issue report is vague. I only noticed the issue when I moved my mouse on fullscreen, trying to make the bars and boxes appear. New version: https://streamable.com/m6aszx Can't show the video of how this issue looks since OBS is having issues properly capturing it (OBS shows a black screen, and takes a while to update)

danilw commented 1 year ago

I saw mention of my https://github.com/u8sand/Baka-MPlayer/issues/313 in this release, but I do not see how it fix my issue with Wayland.

I rebuild to test - in Wayland Baka-MPlayer play in 2 window, self and mpv. In file src/mpvhandler.cpp I have not seen any changes as I mention in my issue:

Fix - file src/mpvhandler.cpp add to line 31:

mpv_set_option_string(mpv, "gpu-context", "x11egl");   // xWayland Sway fix

(x11egl or x11, because mpv use it) it seems for now, tested Apr 2023, it work only with x11egl