search

u9n / dlms-cosem

A Python library for DLMS/COSEM
Other
79 stars 39 forks source link

GetResponse serialization #64

Closed isidroas closed 4 months ago

isidroas commented 1 year ago
isidroas commented 9 months ago

Hello @Krolken I have seen that this is already fixed in the branch 23.1.0alfa

When will that branch be merged to master?

Should I close this merge request?

Krolken commented 4 months ago

Implemented in later versions. Closing. Thanks for caring enough to try and fix it 😄

isidroas commented 4 months ago

Could you merge it to master? I see that the bug is still present, because 23.1.0alfa hasn't been merged yet 2024-02-27-122418_

isidroas commented 4 months ago

That branch also has an important fix:

diff --git a/dlms_cosem/io.py b/dlms_cosem/io.py
--- a/dlms_cosem/io.py
+++ b/dlms_cosem/io.py
@@ -15,6 +15,7 @@ import attr
 import serial

 from dlms_cosem import exceptions
+from dlms_cosem.protocol.wrappers import WrapperHeader, WrapperProtocolDataUnit

 from typing import *