search

uBlock-LLC / uBlock

uBlock: a fast, lightweight, and lean blocker for Chrome, Firefox, and Safari.
https://ublock.org/
GNU General Public License v3.0
8.18k stars 437 forks source link

Interest in skipping t.co and similar? #1538

Closed clipperhouse closed 2 years ago

clipperhouse commented 9 years ago

Would it be in-scope of uBlock to include a “resolver” for t.co links? The DOM of Twitter (and Tweetdeck) usually include the destination URL as an attribute on the href’s.

I’ve implemented this in the past, it’s straightforward enough and can be done inexpensively.

publicarray commented 9 years ago

Personally I think if it just t.co links than it is out of the scope. I mean you already created an add-on for that feature. However if for privacy/security reasons (so the user can see the destination url) we resolved link shorteners e.g. bit.ly links than I think people can benefit from that. Correct me if I am wrong but isn't there a caveat? To resolve resolve a url we need to make a request which of course can be a privacy concern. e.g. We send a request for a link (that could be logged) that the user potentially never clicked on.

RoxKilly commented 9 years ago

If as @clipperhouse mentioned, the destination is listed as an attribute to the Anchor tag, then there will be no need to make any request.

I would agree though that implementing a feature that serves only one domain is too narrow.

clipperhouse commented 9 years ago

Agree that it shouldn’t make a request, it should only take advantage of what’s in the DOM. Could do similarly for google.com. The attributes are:

Twitter: data-expanded-url Google: data-href Tweetdeck: data-full-url

Facebook uses a regular href but logging happens via an onclick, which could simply be removed.