open.spotify.com: breakage

kidgrit commented 2 years ago

Prerequisites

[X] I read and understood the policy as to what is a valid filter issue
[X] I verified that the issue has not already been reported (use this button to find out)
[X] I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")
[X] I did not remove any of the default filter lists, or I verified that the issue is not caused by removing any of the default lists
[X] I did not enable external filter lists, or I verified that the issue still occurs without enabling external filter lists
[X] I do not have custom filters/rules, or I verified that the issue still occurs without custom filters/rules
[X] I am not using another content blocker along uBO (also mind browser built-in blockers)
[ ] I did not answer truthfully to all the above checkpoints

URL address of the web page

https://open.spotify.com/

Describe the issue

Basically before you could click on shuffle or loop to break out of the ad pause and continue listening to music but now that doesnt work and there's no way to listen to music without listening to the ad.

Screenshot(s)

Configuration

```yaml uBlock Origin: 1.43.0 Chromium: 104 filterset (summary): network: 80566 cosmetic: 45321 scriptlet: 17652 html: 0 listset (total-discarded, last updated): default: user-filters: 0-0, never easylist: 69506-51, 19h.23m easyprivacy: 27348-127, 19h.22m plowe-0: 3634-776, 7d.12h.17m ublock-abuse: 76-0, 8d.7h.25m ublock-badware: 4233-92, 19h.21m ublock-filters: 32513-120, 19h.20m ublock-privacy: 231-3, 8d.7h.24m ublock-quick-fixes: 389-37, 19h.18m ublock-unbreak: 1858-43, 19h.19m urlhaus-1: 5167-0, 19h.17m filterset (user): [empty] modifiedUserSettings: [none] modifiedHiddenSettings: [none] supportStats: allReadyAfter: 307 ms (selfie) maxAssetCacheWait: 168 ms popupPanel: blocked: 6 blockedDetails: google.com: 2 googleoptimize.com: 1 googletagmanager.com: 1 sentry.io: 1 spotifycdn.com: 1 ```

MasterKia commented 2 years ago

[X] I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")

Do it twice and test again.

https://github.com/uBlockOrigin/uAssets/issues/14231

0x416c69 commented 2 years ago

@okiehsch It's been working fine since changing to 1s noop sound but now it's broken again:

chrome_2022-08-19_00-31-06

This is a bit hard to reproduce, spotify doesn't always play the same amount of ads and tends to play different amount of ads based on the time of day, also don't forget to hard refresh before trying to reproduce this.

z-aki commented 2 years ago

Steps to redo:

Open your liked songs playlist or any other long one.
keep skipping songs. Every 15th song, there will be an ad.
First two ads will be skipped fine by uBO and next track will automatically start playing.
on the third case however (i.e ~45th song ) a mute audio will play for the length of the ad.
- The skip buttons won't work
- after 30s, nothing will change, ad banner will be there, no audio will be playing, audio slider will be at 30s, next track will not be played
- Double clicking on the song in the playlist will restart the ad audio again, muted still.
- Only way to break out is to refresh the page, but now the song position is lost and you have to scroll down to find which one you were playing.

I have this version of filter list

! Last modified: Sat, 20 Aug 2022 13:21:21 +0000

! https://github.com/uBlockOrigin/uAssets/issues/448
! https://github.com/uBlockOrigin/uAssets/issues/724
! https://github.com/uBlockOrigin/uAssets/issues/14231
||spotify.com/storage-resolve/files/audio/interactive/*$xhr,domain=open.spotify.com
||akamaized.net/audio/*$media,redirect=noopmp4-1s,domain=open.spotify.com
||scdn.co/audio/*$media,redirect=noopmp4-1s,domain=open.spotify.com
open.spotify.com##[href^="https://adclick.g.doubleclick.net/"]
! https://github.com/uBlockOrigin/uAssets/issues/7620
open.spotify.com###leaderboard-ad-element

okiehsch commented 2 years ago

on the third case however

I can reproduce, can you test ||spotify.com/storage-resolve/files/audio/interactive/$badfilter,xhr,domain=open.spotify.com by adding it to your filter list and reload a playlist, it appears to be working on my end.

z-aki commented 2 years ago

on the third case however

I can reproduce, can you test ||spotify.com/storage-resolve/files/audio/interactive/$badfilter,xhr,domain=open.spotify.com by adding it to your filter list and reload a playlist, it appears to be working on my end.

Yes it's fixed!

okiehsch commented 2 years ago

Ok, I pushed the fix, if you update uBlock filters list in a few minutes you can remove the mentioned filter from your list.

kidgrit commented 2 years ago

[x] I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")

Do it twice and test again.

14231

I did this and it's fixed. I apologize for any waste of time I might have caused. Thank you - Next time I will do this double purge before posting.

uBlockOrigin / uAssets