uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.17k stars 773 forks source link

computerbase.de: Microsoft Edge Crash #16613

Closed kloetsack closed 1 year ago

kloetsack commented 1 year ago

Prerequisites

I tried to reproduce the issue when...

Description

Visiting computerbase.de causes Edge to hang for about 30 seconds and generate a crashlog

URL(s) where the issue occurs.

https://www.computerbase.de

Screenshot(s)

No response

uBO version

1.46.0

Browser name and version

Microsoft Edge 109.0.1518.70

Settings

Show Number of Blocked request is OFF About 5 Filters for other websites Reset uBlockOrigin to default and tried different settings/filters/etc.

Notes

Steps to replicate:

Visit https://www.computerbase.de (preferably in a new InPrivate-Window, if not clear cache completely maybe restart browser for each test)

After 'accepting' ads on the paywall Edge will freeze for about 30 seconds (obvious if you open any other links in the background - these tabs will stop loading, pages are completely white, loading-circle on the tab just spins - after about 30 seconds background pages will continue to load)

A .dmp file will be generated when the error occurs - see: edge://crashes/ or (%localappdata%\Microsoft\Edge\User Data\Crashpad\reports)

What I found out so far:

Thanks

mapx- commented 1 year ago
kloetsack commented 1 year ago

I already deleted %localappdata%\Microsoft\Edge\User Data -> complete reset of Edge Reinstalled uBlockOrigin Issue also occurs with default uBlock settings (Filter lists are updated) Disabled all other extensions (problem only occurs, when the first uBlockOrigin filter is checked) No other blocking software installed DNS is not modified System got already restarted a couple of times during the last few days, since I noticed and tried to find the issue

iam-py-test commented 1 year ago

You seem to be behind on updates (the latest Edge is 109.0.1518.78). Can you still repro on the newest version?

kloetsack commented 1 year ago

Thats gotta be pretty new - checked a few hours ago. Gonna test in a min, my crash is on cooldown... It definitely only happens, when i check this first uBO filterlist. Tried disabling trackin protection and defender smart screen, reset uBO -> still happening

Filterlist: Checked -> dmp file unchecked -> nothing

Tried unchecking the filterlist i mentioned but copied its content into 'my filters' -> dmp file, browser hang Damn I thought I had something, but edge://crashes/ itself just would not update, because of this whole issue.

Gonna update and check, back in a few minutes

kloetsack commented 1 year ago

OK, updated Edge, cleared cache/etc, no other extensions active, reset uBO und updated filters, disabled Edge tracking protection/defender smart screen/and something with secure dns in edge open new inprivate window - visit site - click the popup away - close inprivate, back to regular window - edge://crashes/ and i got a new dmp file.

@mapx: did you get the popup? don't clear history right after visiting the site, it also clears dmp files

kloetsack commented 1 year ago

So I got it to not crash I think - at least once. What I did: deleted %localappdata%\Microsoft\Edge\User Data -> complete reset of Edge (settings, extensions, bookmarks...) Open Edge, skip through the settings page so I can use the browser, installed uBlockOrigin, updated Filters, went to computerbase (no dmp so far) clicked the popup away - and it still seemed fine. Reopened Edge and tried again - crashed again

iam-py-test commented 1 year ago

Wonder if anyone here has the skills to analyze a dump file. A few questions: Do you use Edge's sync? Do you sign into Edge? If uBo installed from the Microsoft extensions store or the Chrome one? I can't reproduce with either I am not part of the uBo team, just a random person trying to help

kloetsack commented 1 year ago

No Edge sync, Not signed in. Tried uBO from both, normally Edge store, after this reset chrome store, doesn't matter. I tried opening the dbg files with BlueScreenView - didn't work Tried WinDbg from Microsoft Store didn't really tell me much... something with msedge_elf.dll

iam-py-test commented 1 year ago

Odd. Do you have any security software installed (firewall, antimalware, etc)?

kloetsack commented 1 year ago

To sum this all up a little bit - the issue only happens:

But: when setting computerbase.de googlesyndication.com allow and computerbase.de googletagmanager.com allow -> no dbg file (even with first uBO filterlist enabled)

@iam-py-test: No, just Windows 10 default

kloetsack commented 1 year ago

A few more things... Given the fact that it works after the first Edge start after a complete reset (only installing uBO) seems to me like this is not a pc problem on my end (I even tried and repaired Edge via apps - Edge - change and then repair). When i then restart the browser the issue starts to happen. IDK what exactly Edge updates in the %localappdata%\Microsoft\Edge\User Data folder that propably is part of the problem, but this should not be a only me problem (since i did nothing but install uBO until then) but happen to everyone else using Edge with uBO and visiting this site and propably some other sites which try to load the same stuff than this one? One thing I just noticed is that this site has a WebApp - I never installed it and there is no popup or something that tries to make you install it - just saying. app

Also the (kinda paywall) popup mentioned above isn't really relevant to the issue. As long as it is displayed there is no problem (besides you can't view the site). I only get a dmp file after clicking it away. Also if I close the site, wait 5 minutes and then reopen it -> hang and dmp file.

stephenhawk8054 commented 1 year ago

You might need to use Chromium Profiler and upload the saved profile here so someone else can investigate it.

krystian3w commented 1 year ago

Also Possible test on Edge Beta: https://www.microsoftedgeinsider.com/en-us/download/beta

Dev: https://www.microsoftedgeinsider.com/en-us/download/dev

or Canary: https://www.microsoftedgeinsider.com/en-us/download/canary

garry-ut99 commented 1 year ago

Invalid, browser crashes are a browser issue:

https://github.com/uBlockOrigin/uBlock-issues/issues/3205#issuecomment-2053618513
https://github.com/uBlockOrigin/uBlock-issues/issues/2882#issuecomment-1769079212
https://github.com/uBlockOrigin/uBlock-issues/issues/2851#issuecomment-1751669794
https://github.com/uBlockOrigin/uBlock-issues/issues/2471#issuecomment-1408861964
https://github.com/uBlockOrigin/uBlock-issues/issues/2467#issuecomment-1403214770
https://github.com/uBlockOrigin/uBlock-issues/issues/2074#issuecomment-1086288841
https://github.com/uBlockOrigin/uBlock-issues/issues/1530#issuecomment-801404412
https://github.com/uBlockOrigin/uBlock-issues/issues/1171#issuecomment-662520037
https://github.com/uBlockOrigin/uAssets/issues/16613#issuecomment-1415835892
https://github.com/uBlockOrigin/uAssets/issues/8058#issuecomment-712962803

Only "freezing" issues are accepted, example: https://github.com/uBlockOrigin/uBlock-issues/issues/2469

kloetsack commented 1 year ago

Invalid, browser crashes are a browser issue: uBlockOrigin/uBlock-issues#2471 (comment) Only "freezing" issues are accepted, example: uBlockOrigin/uBlock-issues#2469

Edge doesn't crash, it freezes for 10-60 seconds, which is why sometimes you can't really notice because it keeps working again after a few secs. That's why looking at edge://crashes/ is how to see that something is off. Browserwindow stays open all the time, you can switch tabs, they just don't load/reload. When you got uBO settings page open you can reload it but not change between its settings tabs. It seems like it just goes offline.

kloetsack commented 1 year ago

Gonna look at Chromium Profiler and test Beta/Dev... maybe even other Chromium browser.

Has anyone been able to at least reproduce this jet?

kloetsack commented 1 year ago

First uBO filterlist off (no dmp) https://user-images.githubusercontent.com/124305110/216659011-7dce9abe-6016-44ee-93e4-1b75e2cf7b4a.png

First uBO filterlist on (freeze, dmp file) https://user-images.githubusercontent.com/124305110/216659119-c12c0be8-1d46-4971-9e31-3485c8feb3b9.png

stephenhawk8054 commented 1 year ago

Screenshot images will not help. Did you save the profile as instruction?

https://developer.chrome.com/docs/devtools/performance/reference/#save

kloetsack commented 1 year ago

I did save them, just looking into them right now. If theres something in particular that you need, let me know. I know that screenshots are not the best way to do this, but I don't know how much info is in there and how I feel about uploading them jet...

A few more from when the freeze happens:

https://user-images.githubusercontent.com/124305110/216669231-1e505932-c228-4131-9d56-a7d16e7b89f8.png

https://user-images.githubusercontent.com/124305110/216669242-c801f27c-4a04-49bb-b244-607b645e4934.png

https://user-images.githubusercontent.com/124305110/216669248-00ebd717-e22c-4289-af83-88f971af55c6.png

kloetsack commented 1 year ago

First uBO filterlist off (no dmp) https://user-images.githubusercontent.com/124305110/216675952-3832386f-daab-40d9-b5ca-61a9bfd64d20.png

First uBO filterlist on (freeze, dmp file) https://user-images.githubusercontent.com/124305110/216675965-930b7a4f-995c-4557-9a9a-a9d2b21e7f57.png

kloetsack commented 1 year ago

I just tried Edge Beta which also generates a dmp file. Also tried Chrome and it also generates a dmp file (has to be activated first, see chrome://crashes)

https://user-images.githubusercontent.com/124305110/216685893-74d61e89-42b8-4aa9-b952-74831fb5e237.png

Both show the exact same behavior as Edge described above uBO extension off -> works, no dmp, no freeze uBO extension on, first uBlock filterlist off -> works, no dmp, no freeze uBO extension on, first uBlock filterlist on -> does not work, dmp, freeze

stephenhawk8054 commented 1 year ago

Can you upload the saved profile file here? So others can help investigate.

kloetsack commented 1 year ago

Honestly I'd prefer if someone here would able to reproduce the issue and then check his own devtools recordings... I have no idea what exactly gets logged there and that I might not want to post publicly. If someone has an idea and points me to where to look/what to klick - I will post more screenshots of that.

Tomorrow I might be able to check on a different PC and see if it also freezes on that site with uBO

stephenhawk8054 commented 1 year ago

Not sure if it's geo-related or not. @okiehsch @JobcenterTycoon Sorry can you reproduce the issue?

okiehsch commented 1 year ago

No.

mapx- commented 1 year ago

@kloetsack test this filter

@@||googletagmanager.com/gtag/js$xhr,domain=computerbase.de

krystian3w commented 1 year ago

This can be small A/B Test be webmaster.

kloetsack commented 1 year ago

I just tested it at someone elses PC Edge - no extensions - works fine

@mapx tried, still generates dmp.

Edit: i'm stupid, testing some rules...

krystian3w commented 1 year ago

Maybe main script adsbegoogle.js is still red.

kloetsack commented 1 year ago

Thats how it looks now (with @@||googletagmanager.com/gtag/js$xhr,domain=computerbase.de) https://user-images.githubusercontent.com/124305110/216788779-c3056267-aea4-42b4-8bc0-5e94dafe9bc1.png

krystian3w commented 1 year ago

Learn how use logger:

https://github.com/gorhill/uBlock/wiki/The-logger

His red rows may better show what is still locked and what as green unlocked resources/request like https://github.com/uBlockOrigin/uAssets/issues/16613#issuecomment-1416778480

kloetsack commented 1 year ago

OK, so on top of filter that mapx posted: @@||googletagmanager.com/gtag/js$xhr,domain=computerbase.de

I added:

@@||pagead2.googlesyndication.com/pagead/js/*$xhr,domain=www.computerbase.de
@@||pagead2.googlesyndication.com/pagead/managed/js/adsense/*$xhr,domain=www.computerbase.de
@@||pagead2.googlesyndication.com/getconfig/*$xhr,domain=www.computerbase.de

And I get no dmp file anymore. I am not sure if this can be done with less exeptions... Will this eventually be put into a uBO filter?

One more thing:

I don't think that this is a site-specific problem. When I tested on someone elses PC today, I happened to find Opera already installed, so I tested there too. First nothing - no dmp files. Then I realized that Opera was still on v94 (chromium 108.xxx). So I ran an update, tested again and got dmp files! And I also found threads with people complaining about getting lots of these dmp files in different chromium based browsers - starting with v109.xxx

krystian3w commented 1 year ago

As far as I'm concerned, this can disrupt privacy, so maybe it's better to wait for it to be fixed at the Chromium level - check their issues tracker:

https://crbug.com

kloetsack commented 1 year ago

Well, after spending quite some time on figuring out this issue over the last few days, I think i'll pass on digging through 64000 bug reports... I will keep these filters in my uBO for now and check if the issue is completely fixed that way or if freezes still occur with or even without dmp files being generated. Then propably going to disable them every now and then or when Edge gets updated and test if it got fixed.

garry-ut99 commented 1 year ago

kloetsack : I am not sure if this can be done with less exeptions...

It can be done by a single broader exception:

@@||pagead2.googlesyndication.com/*$xhr,domain=computerbase.de

kloetsack : Will this eventually be put into a uBO filter?

No, unless it will either:

mapx- commented 1 year ago

closing for now but you can still comment here