uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.2k stars 776 forks source link

hyundai-motor.com.tw: breakage #17824

Closed cmyang2005 closed 1 year ago

cmyang2005 commented 1 year ago

Prerequisites

URL address of the web page

https://www.hyundai-motor.com.tw/clicktobuy/custin

Category

breakage

Description

breakage

Screenshot(s)

Screenshot(s)

Configuration

```yaml uBlock Origin: 1.49.0 Firefox: 112 filterset (summary): network: 107118 cosmetic: 50324 scriptlet: 17924 html: 953 listset (total-discarded, last-updated): default: user-filters: 0-0, never ublock-filters: 34882-67, 3d.23h.58m ublock-badware: 6866-0, 3d.23h.57m ublock-privacy: 345-0, 12d.32m ublock-abuse: 70-0, 12d.31m ublock-unbreak: 2010-2, 3d.23h.56m ublock-quick-fixes: 203-0, 6m easylist: 65496-677, 4d.2m easyprivacy: 30891-1789, 4d urlhaus-1: 6994-1, 5m plowe-0: 3749-2, 12d.29m CHN-0: 27641-113, 3d.23h.59m filterset (user): [empty] modifiedUserSettings: [none] modifiedHiddenSettings: [none] supportStats: allReadyAfter: 924 ms (selfie) maxAssetCacheWait: 227 ms popupPanel: blocked: 9 network: hyundai-motor.com.tw: 1 appier.net: 2 facebook.net: 1 googletagmanager.com: 1 line-scdn.net: 1 scupio.com: 1 yimg.com: 2 ```
gorhill commented 1 year ago

Broken by EasyPrivacy's /js/tracking.js. This fixes it:

@@||hyundai-motor.com.tw/modules/js/tracking.js$script,1p

cc @ryanbr

stephenhawk8054 commented 1 year ago

I think redirect-rule is enough, no need for allowing?

||hyundai-motor.com.tw/modules/js/tracking.js$script,redirect-rule=noopjs
gorhill commented 1 year ago

I forgot to check with redirect-rule. Problem is redirect-rule are discarded with uBOL because this can't be repsented by a DNR rule, so the site will still be broken with uBOL. From what I see in the JS content of that file, it doesn't seem to be doing much, and also it's first party.

redirect is ok though, so maybe ||hyundai-motor.com.tw/modules/js/tracking.js$script,redirect=noopjs, but given it's 1st-party and it's very simple script, I say we leave it to EasyPrivacy, which anyway would end up unblocking the request such that the redirect would become pointless.

MasterKia commented 1 year ago

||hyundai-motor.com.tw/modules/js/tracking.js$script,redirect=noopjs,important

gorhill commented 1 year ago

I know about important, just not worth.

MasterKia commented 1 year ago

Ok. I meant we already counter some of EasyPrivacy's exception that way.

https://github.com/uBlockOrigin/uAssets/blob/ca6b458a44c85c4f4dd7a2e935986a391c0cf3be/filters/unbreak.txt#L4762

https://github.com/uBlockOrigin/uAssets/blob/ca6b458a44c85c4f4dd7a2e935986a391c0cf3be/filters/unbreak.txt#L4747

https://github.com/uBlockOrigin/uAssets/blob/ca6b458a44c85c4f4dd7a2e935986a391c0cf3be/filters/unbreak.txt#L4467