uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.07k stars 762 forks source link

learncpp.com: ads #18717

Closed KAGEYAM4 closed 1 year ago

KAGEYAM4 commented 1 year ago

Prerequisites

URL address of the web page

https://www.learncpp.com/ https://www.learncpp.com/cpp-tutorial/the-virtual-table/

Category

ads

Description

Ads Placeholder still remains even though ads do not show up.

Additionaly if i click on those placeholder, the screen dims and mouse loading animation starts and then after few seconds it goes away.

Other extensions used

Screenshot(s) ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/61309f71-e340-483a-b8e6-41f0677bb70b) ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/540c5bb0-808b-4c0d-9c30-711ee5b1a64c) ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/22073d62-602e-4310-af39-c83be9397b1f) ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/c8731afc-126b-4ced-ab45-648bb3504df1)

Screenshot(s)

Screenshot(s) How it is (Firefox) -> ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/9c63a390-12c1-4775-a40e-6c47da6cf209) ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/f204e914-791e-47a2-80f1-140bd43b8fde) How it should be (Mullvad Browser) ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/cd3af237-24e9-4424-9bc2-ce084a66a886) ![image](https://github.com/uBlockOrigin/uAssets/assets/75798544/27025515-7337-4149-986c-9c0dae17ce64)

Configuration

```yaml uBlock Origin 1.50.0: since: 14d.47m Firefox: 114 filterset (summary): network: 97226 cosmetic: 84092 scriptlet: 23175 html: 1136 listset (total-discarded, last-updated): added: adguard-spyware-url: 1097-5, 4m fanboy-cookiemonster: 47643-156, never ublock-annoyances: 5259-7, 4m default: user-filters: 2-0, never ublock-filters: 34510-100, 4m ublock-badware: 7631-1, 4m ublock-privacy: 457-0, 4m ublock-unbreak: 2081-1, 4m easylist: 67585-739, 4m easyprivacy: 30615-710, 4m urlhaus-1: 6604-0, 4m plowe-0: 3739-1, 4m ublock-quick-fixes: 283-0, 4m filterset (user): [array of 2 redacted] trustedset: added: [array of 89 redacted] hostRuleset: added: [array of 200 redacted] userSettings: advancedUserEnabled: true hiddenSettings: filterAuthorMode: true supportStats: allReadyAfter: 2924 ms (selfie) maxAssetCacheWait: 190 ms popupPanel: blocked: 21 network: learncpp.com: 12 amazon-adsystem.com: 1 doubleclick.net: 1 ezodn.com: 2 google-analytics.com: 1 googlesyndication.com: 1 pubmatic.com: 1 quantserve.com: 1 teads.tv: 1 extended: ##[data-ez-name] ##[id^="google_ads_iframe"] ##div[id^="ezoic-pub-ad-"] ##span[id^="ezoic-pub-ad-placeholder-"] ##[id^="div-gpt-ad"]:not([style^="width: 1px; height: 1px; posit… ###ezmobfooter ##.ezmob-footer ##.ezoic-floating-bottom ##.ezo_ad ##.ezmob-footer-desktop ##.ezoic-ad ##.adtester-container #@#[id^="div-gpt-ad"] #@#.ad-unit #@#.banner-ads #@#.banner_ads #@#.ad-zone #@#.ad-space ```
stephenhawk8054 commented 1 year ago

It's hidden correctly for me, screenshot: https://github.com/uBlockOrigin/uAssets/assets/66517106/f2654027-877c-4a98-bc08-4f2099cddc49

okiehsch commented 1 year ago

The site is unusable for me becuase I can't click the GDPR modal. I will add a fix for that issue.

krystian3w commented 1 year ago

EL cookies addresed cookie prompt by generic:

###ez-cookie-dialog-wrapper

same AdGuard Cookie notices and optional list "I don't care about cookies".

3 projects have 0 obvious exception for cosmetic filtering.

okiehsch commented 1 year ago

That doesn't help the user with a default setup.

krystian3w commented 1 year ago

So you meant all list should implement too:

learncpp.com#@##ez-cookie-dialog-wrapper

what function out of modal is broken without minimal/full accept?

KAGEYAM4 commented 1 year ago

Both Webpages for issue mentioned above, now correctly works. One time it wasn't , now its working.

krystian3w commented 1 year ago

It is possible that they are testing a new way of injecting ads and, because of the failure, have revoked the reservation of ad space.

KAGEYAM4 commented 1 year ago

Update - It's working in container ( firefox multi-account container ) but not otherwise

okiehsch commented 1 year ago

So you meant all list should implemen

No. what I mean is we have to fix a broken site if it is broken with a default setup.

what function out of modal is broken without minimal/full accept?

I can't click "Continue with Recommended Cookies" and without clicking that button the site will not function.

krystian3w commented 1 year ago

But I'm not asking why you're allowing a JS file, I'm asking what you have broken after using the filter:

learncpp.com###ez-cookie-dialog-wrapper#ez-cookie-dialog-wrapper

(Those willing can convert the cosmetic filter to a rejecting one using set.js or in uBo dev set-cookie / trusted-set-cookie / trusted-set-local-storage)

That allowing JS seems better.

okiehsch commented 1 year ago

I'm asking what you have broken after using the filter: learncpp.com###ez-cookie-dialog-wrapper#ez-cookie-dialog-wrapper

The ability to interact with your GDPR settings.

krystian3w commented 1 year ago

Well, let you have this evasive answer (In this way, we can disprove the sense of the whole list of EL Cookies, that people will close themselves).

okiehsch commented 1 year ago

It's not evasive, we don't fix, i.e. hide cookie notices or GDPR modals for users with a default setup. If I use your suggested filter that's exactly what I would be doing.

okiehsch commented 1 year ago

It's hidden correctly for me, screenshot: https://github.com/uBlockOrigin/uAssets/assets/66517106/f2654027-877c-4a98-bc08-4f2099cddc49

Hm, it was the same on my end but now I can reproduce.

@KAGEYAM4 does it work for you if you add learncpp.com##.cf_monitor to your filter list?

KAGEYAM4 commented 1 year ago

@okiehsch now even i can't reproduce. It's working perfectly now. didn't even used learncpp.com##.cf_monitor.

okiehsch commented 1 year ago

Maybe it's a site issue. I will close for now, if the issue reappears just post it here.