uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
3.98k stars 753 forks source link

bandcamp.com: breakage #19320

Closed ghost closed 1 year ago

ghost commented 1 year ago

Prerequisites

URL address of the web page

https://merregnonrecords.bandcamp.com/album/final-symphony-ii-music-from-final-fantasy-v-viii-ix-and-xiii?from=hp

Category

breakage

Description

AdGuard Social Media incorrectly hides the Embed link, which is the necessary for generating and customizing iframe codes. It's not a social media sharing button. The AdGuard maintainers refused to fix this.

Other extensions used

-

Screenshot(s)

Screenshot(s) ![68747470733a2f2f63646e2e616467756172642e696e666f2f736974657265706f7274732f31396d7a31386e3375643867386777306f6f77676f6f387373343430637734646732713438736566766b2e706e673f6e633d31](https://github.com/uBlockOrigin/uAssets/assets/135860000/77271672-ba80-43f7-8f5d-d2a183512d69)

Configuration

```yaml uBlock Origin: 1.51.0 Firefox: 116 filterset (summary): network: 164692 cosmetic: 160280 scriptlet: 39921 html: 1204 listset (total-discarded, last-updated): added: adguard-generic: 73038-6691, 1m adguard-spyware-url: 1175-6, 1m adguard-spyware: 59029-17090, now block-lan: 48-0, now adguard-social: 21134-908, now adguard-cookies: 26565-45, now adguard-popup-overlays: 23292-157, now adguard-mobile-app-banners: 4489-7, now adguard-other-annoyances: 13222-59, now adguard-widgets: 2266-1, now ublock-annoyances: 5311-263, now spa-1: 5431-11, now [1 lists not shown]: [too many] default: user-filters: 1-0, never ublock-filters: 35077-458, 2m ublock-badware: 7679-0, 2m ublock-privacy: 481-0, 2m ublock-unbreak: 2152-0, 2m ublock-quick-fixes: 261-0, 3m easylist: 69814-885, 1m easyprivacy: 33270-792, now urlhaus-1: 6095-0, 3m plowe-0: 3715-2, now filterset (user): [array of 1 redacted] userSettings: advancedUserEnabled: true contextMenuEnabled: false showIconBadge: false hiddenSettings: [none] supportStats: allReadyAfter: 13000 ms (selfie) maxAssetCacheWait: 7441 ms popupPanel: blocked: 2 network: bcbits.com: 2 extended: ##.tos-update ##.share-embed ```
okiehsch commented 1 year ago

Issues caused by Adguard filters are best opened at https://github.com/AdguardTeam/AdguardFilters

@Yuki2718 Hidden by bandcamp.com##.share-embed

Yuki2718 commented 1 year ago

The problem is if we remove, someone will report it as missed social button again. Will comment out.

ghost commented 1 year ago

@okiehsch People take their time to fill in these issue reports. Please read them before closing them.

The AdGuard maintainers refused to fix this.

@gorhill This filter is breaking site functionality. It's not a social media annoyance. It's an iframe generator people use to add albums to their own sites.

okiehsch commented 1 year ago

My bad, I should have noticed that but it does not change the fact that we only fix issues caused by a default setup in this repo. We are not a "super-repo" that fixes issues caused by all available filter lists.

stephenhawk8054 commented 1 year ago

If the specialized filter lists declined the requests, we won't do more. If we override it, what should we do if someone else come here to complain about the button not being hidden when enabling that list?

Yuki2718 commented 1 year ago

The AdGuard maintainers refused to fix this.

TBH I'm also curious why it was declined. @TatianaPink Can you post the link of the refusal? The only chance it can be addressed will be by re-arguing with @Alex-302 and I'm pro for that, the button is just ignorable in my eyes and not a social media sharing.