photopea.com: breakage

[photopea]

Prerequisites

• [X] I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• [X] This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• [X] I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• [X] The issue is not present after disabling uBO in the browser.
• [X] I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• [X] uBO is the only extension.
• [X] uBO uses default lists and settings.
• [X] using a new, unmodified browser profile.

Description

When my users visit my website www.Photopea.com , and they allow uBlock Origin to have a total control of a website (read and rewrite the information), your extension modifies the look of Photopea and it is impossible to use it (the right side is cut-off).

The issue was reported to me by dozens of users, but I am afraid it happens to hundreds of thousands, who simply dont report it and think that Photopea is broken. Here are three of them

https://github.com/photopea/photopea/issues/6024 https://github.com/photopea/photopea/issues/5878 https://github.com/photopea/photopea/issues/5844

A specific URL where the issue occurs.

www.Photopea.com

Steps to Reproduce

1. Open www.Photopea.com with the uBlock Origin extension
2. It looks differently than without it

Expected behavior

The website should be usable

Actual behavior

The website is not usable

uBO version

latest

Browser name and version

latest Chrome

Operating System and version

Windows 10

[MasterKia]

Hi, I believe you're the creator of this website.

So there's an anti-blocker notice and ad-reinjection on the site (sometimes an ad for a game is injected if a content blocker is detected):

https://github.com/uBlockOrigin/uAssets/assets/17685483/3f6c9f88-7ac4-49c7-a2d6-4b045e777197

Without the anti-blocker, there's a giant unusable placeholder left on the right side which is very annoying: https://github.com/uBlockOrigin/uAssets/assets/17685483/2d3a913b-a4e0-41e1-9eff-c128dec581a4

So I added a filter to restore the site to its maximum size using this project: https://github.com/jared-schwalbe/remove-ads-from-photopea

Me and @iam-py-test tested the site and it was working fine. https://github.com/uBlockOrigin/uBlock-issues/issues/2731#issuecomment-1631615533

If the filter is breaking the site for some users, we will remove it.

Could you propose a way for us to restore the site to its maximum size without breaking it?

[MasterKia]

User reports:

https://www.reddit.com/r/photopea/comments/mq45p0/how_to_remove_dead_space_on_right_side/

https://www.reddit.com/r/photopea/comments/plkr5l/what_is_this_empty_panel_and_how_do_i_get_rid_of/

https://www.reddit.com/r/photopea/comments/13zatws/how_to_get_rid_of_this_empty_space_on_right_side/

https://www.reddit.com/r/photopea/comments/p46w6e/why_is_there_so_much_free_space_on_the_right_side/

https://www.reddit.com/r/photopea/comments/126lhdj/anyone_know_why_the_right_side_of_my_screen_is/

[photopea]

This is related to people who pay for Photopea Premium (the "Account" button at the top is green), who do not see any ads. You still stretch the UI for them.

[photopea]

I think I have fixed it. Since you are re-setting window.innerWidth, I have switched to the property window.screen.width .

BTW. I am tolerating the ad-blockers for now. But you should not apply any "cracks" to my source code to allow people use my Premium features (full-screen interface) for free. That is basically the same as piracy, and you are facilitating it.

[HelderRocket]

It happens to me with the Edge browser. While I use an ad blocker (Adblock), I have the page in the exclusions list. And in fact, even though I have the extension disabled, the ads still don't come up.

https://github.com/uBlockOrigin/uAssets/assets/104467221/03f8f309-9edf-472b-902d-568ecac8cb04

I thought it might be some additional browser settings, however also in those settings I have the page excluded and it still does not appear (Enhanced security and tracking prevention).

https://github.com/uBlockOrigin/uAssets/assets/104467221/b8195d2a-efaa-4577-9507-1dc38031c6f3

[okiehsch]

But you should not apply any "cracks" to my source code to allow people use my Premium features (full-screen interface) for free.

We don't circumvent paywalls, see https://github.com/uBlockOrigin/uAssets#readme

We do add filters to circumvent anti adblock walls and ad-reinsertion and we don't check if the same filter breaks your paywall too.

[MasterKia]

There is no paywall to break, one of the site's premium "features" is to give you no ads and more horizontal space.

Just like many other sites that offer an "ad-free" experience for premium users.

[MasterKia]

BTW. I am tolerating the ad-blockers for now.

If you make the anti-blocker dismissable, we could remove the anti-blocker filters.

[photopea]

What do you mean by "make the anti-blocker dismissable, we could remove the anti-blocker filters"? What are anti-blockers and anti-blocker filters?

BTW. what would be the right way to detect, that your extension is in charge of a website, so we can ask our users to disable the ad blocker? Do you provide any interface for this?

[MasterKia]

make the anti-blocker dismissable

i.e. making that "Ad blocker detected" warning dismissible, meaning the user could opt to close it.

Something like this (the red ❌ button next to "Ad blocker detected"): https://github.com/uBlockOrigin/uAssets/assets/17685483/92716661-daa6-4642-89c7-6bf1421382f7

way to detect, that your extension is in charge of a website

Aren't you already detecting uBO?

[photopea]

When a user with an adblock uses my service, I can either prevent them completely from using it, or show them a message asking to disable the ad blocker (which should stay on the screen permanently).

Seems like you are removing both my ads and my message. Could you fix it? Otherwise, I will detect that the message is removed, and block the user completely (and you could lose a lot of users - you will not be able to track them across all their websites anymore, or replace the content they read, etc).

[MasterKia]

Could you fix it?

We don't fix dismissible detection notices in the main list, if you make the detection notice closable we won't block it.

[photopea]

Ok, I have fixed it from my side. Now, Photopea will correctly detect the usage of uBlock Origin, and the message about the ad blocking is displayed to the user (permanently).

[photopea]

It happens to me with the Edge browser. While I use an ad blocker (Adblock), I have the page in the exclusions list. And in fact, even though I have the extension disabled, the ads still don't come up.

https://github.com/uBlockOrigin/uAssets/assets/104467221/03f8f309-9edf-472b-902d-568ecac8cb04

I thought it might be some additional browser settings, however also in those settings I have the page excluded and it still does not appear (Enhanced security and tracking prevention).

https://github.com/uBlockOrigin/uAssets/assets/104467221/b8195d2a-efaa-4577-9507-1dc38031c6f3

Actually, the AdBlock extension is lying to their users. You tell them not to do ad blocking on some website, but they still keep blocking ads (that is what you did). I recommend you to switch to better ad blockers (AdBlock Plus, uBlock Origin) which do allow you to turn it off completely for a specific domain.

I even wrote this article, which should help people, who cannot see ads in Photopea properly: https://www.photopea.com/tuts/ads-in-photopea-do-not-work-what-to-do/

[photopea]

@MasterKia You still have not fixed it. There are lots of people struggling because of your extension, and I have to tell each one explicitly to turn your extension off :( This is just for today:

https://github.com/photopea/photopea/issues/6117 https://www.reddit.com/r/photopea/comments/17e9l9e/so_i_finally_succumbed_and_paid_for_photopea_only/

[MasterKia]

@photopea What's the best approach to defuse the anti-blocker notice (and adjusting the panel width to max) without breaking the site; We won't add that "fix" in uBlock Origin's main filterlists.