disqus.com: privacy

[D4niloMR]

Prerequisites

• [X] I read and understand the policy about what is a valid filter issue.
• [X] This is NOT a YouTube, Facebook or Twitch report.
• [X] I verified that this issue is not a duplicate. (Use this button to find out.)
• [X] I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
• [X] I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
• [X] I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
• [X] I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
• [X] I am not using uBlock Origin (uBO) along with other content blocker extensions.
• [x] I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
• [ ] I did not answer truthfully to ALL the above checkpoints.

URL address of the web page

https://disqus.com/home/inbox/

Category

privacy

Description

This isn't working anymore:

disqus.com##+js(href-sanitizer, a[href^="https://disq.us/url?url="][title^="http"], [title])

(See screenshot) Works to me:

disqus.com##+js(href-sanitizer, a[href^="https://disq.us/?url=http"], ?url)
disqus.com##a[href][data-link-out]:remove-attr(data-link-out)

I tested also with a new profile on Firefox.

Other extensions used

none

Screenshot(s)

Screenshot(s)


Configuration

```yaml uBlock Origin: 1.52.3b6 Chromium: 116 filterset (summary): network: 119923 cosmetic: 193351 scriptlet: 30141 html: 0 listset (total-discarded, last-updated): added: https://gitlab.com/magnolia1234/bypass-paywalls-clean-filters/-/raw/main/bpc-paywall-filter.txt: 958-0, 1h.47m https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt: 2495-0, 1h.47m adguard-cookies: 27804-31, 1h.48m adguard-mobile-app-banners: 4656-9, 1h.48m adguard-other-annoyances: 13648-7, 1h.48m adguard-popup-overlays: 24589-64, 1h.48m adguard-social: 21880-921, 1h.47m adguard-widgets: 2317-4, 1h.47m easylist-annoyances: 3993-203, 1h.47m easylist-chat: 141-11, 1h.47m easylist-newsletters: 6537-424, 1h.47m easylist-notifications: 2712-1445, 1h.47m [5 lists not shown]: [too many] default: user-filters: 98-3, never easylist: 71726-70, 1h.50m easyprivacy: 33234-179, 1h.50m plowe-0: 3726-1070, 1h.50m spa-1: 5642-71, 1h.50m ublock-badware: 7297-134, 1h.50m ublock-filters: 34932-558, 1h.50m ublock-privacy: 559-53, 1h.50m ublock-quick-fixes: 236-97, 1h.50m ublock-unbreak: 2142-36, 1h.50m urlhaus-1: 12055-0, 1h.50m filterset (user): [array of 62 redacted] switchRuleset: added: [array of 1 redacted] userSettings: advancedUserEnabled: true suspendUntilListsAreLoaded: true hiddenSettings: userResourcesLocation: [redacted] supportStats: allReadyAfter: 780 ms (selfie) maxAssetCacheWait: 233 ms popupPanel: blocked: 14 network: disqus.com: 5 amazon-adsystem.com: 1 amplitude.com: 1 d2pjwyttpedx35.cloudfront.net: 1 doubleclick.net: 1 googletagmanager.com: 1 osano.com: 1 rfihub.net: 1 rubiconproject.com: 1 wknd.ai: 1 extended: ###adhesion ##.ad-slot-wrapper ##.ad__align ##div[data-role="motd-alert"] ##.ad__adh-wrapper ##[data-role="ad-content"] ##a[href="/home/explore/"] ##+js(href-sanitizer, a[href^="https://disq.us/url?url="][title^… ```

[D4niloMR]

That was fast!! Thank you

[dimisa-RUAdList]

@stephenhawk8054 Something wrong

http://disq.us/p/2vt2qs2

Screenshot(s)


[stephenhawk8054]

Thanks, I overlooked that. Updated.

[dimisa-RUAdList]

@stephenhawk8054 Why here [title^="http"]? The scriptlet itself checks the validity of the link.

[stephenhawk8054]

I just try to limit the number of elements via CSS first before it's feeded to js. Won't be different too much, just my habit of trying to optimize.

[dimisa-RUAdList]

In this case need: disqus.com##+js(href-sanitizer, a[href^="https://disq.us/"][href*="?url=http"]:not([title^="http"]), ?url)

[stephenhawk8054]

Aren't these 2 cases already separated?

disqus.com##+js(href-sanitizer, a[href^="https://disq.us/url?url="][title^="http"], [title])
disqus.com##+js(href-sanitizer, a[href^="https://disq.us/?url=http"], ?url)

I don't think a[href^="https://disq.us/url?url="] can overlap with a[href^="https://disq.us/?url=http"]?

[dimisa-RUAdList]

Oh, well, yes.

[D4niloMR]

@stephenhawk8054 Hey, i think that this filter can be aprimorated for a very specific case, if the user send a non valid link.

~This can be seem at: http://disq.us/t/4jxcu1t~

https://github.com/uBlockOrigin/uAssets/assets/70459964/cbdfbb98-4408-489e-849c-2e192ffb8a2c

disqus.com##+js(href-sanitizer, a[href*="://disq.us/url?url="][title], [title])

The other one is not necessary.

[stephenhawk8054]

If it's invalid, there's no point to rewrite it? As the "link" cannot connect to anywhere.

[D4niloMR]

If it's invalid, there's no point to rewrite it? As the "link" cannot connect to anywhere.

Makes sense, but the user is still going to Disqus redirector unnecessarily, considerating that this filter is in the privacy list, this is a point.

[D4niloMR]

I have encountered a working link which is not covered by the current filter.

http://disq.us/p/2vt3yeh

Although I'm not sure why but it does not works correctly with the filter I proposed https://github.com/uBlockOrigin/uAssets/issues/20066#issuecomment-1783984502

Filtered:

<a href="https://disqus.com/embed/comments/apnews.com" rel="nofollow noopener" title="apnews.com">apnews.com</a>

Not filtered:

<a href="http://disq.us/url?url=http%3A%2F%2Fapnews.com%3Ak6Or9PUqTwGOPpq728-qWPrvuaI&amp;cuid=1290197" rel="nofollow noopener" title="apnews.com">apnews.com</a>

[stephenhawk8054]

Both links are http (without s), so the filter should be adjusted to a[href^="http"]. However with the second http, href-sanitizer won't work iirc from the code.

[D4niloMR]

I guess it's supposed to not work, the attribute to extract the link doesn't have https or http. The scriptlet is doing its job, but to work properly is necessary to add https at the start.

@gorhill