Closed THEtomaso closed 8 months ago
IMO for ELC (have similar filtering per defined domain), fyi @Nojuuu / @peace2000
If it doesn't need trusted filters it can probably be handled in ELC
Blocking wrapperMessagingWithoutDetection.js
seems fine to me. Videos work and so do twitter embeds. These two things are the most common thing to break, if something is going to break.
Sample links:
https://www.vl.no/religion/2024/02/12/kvinnelig-gjerningsperson-skutt-etter-skyting-i-megakirke-i-texas-to-saret/
https://www.tu.no/video/digi-forklarer-nodvarsling-pa-mobil/2142
https://www.tu.no/artikler/samlet-inn-over-3-85-millioner-kroner-ble-suspendert-av-kickstarter/223165
https://www.digi.no/artikler/teslas-nye-robot-kan-bli-et-av-selskapets-viktigste-produkter/541307
https://www.digi.no/artikler/eu-strever-med-a-enes-om-banebrytende-ki-regler/540835
https://www.dagsavisen.no/video/2024/01/27/anders-gjose/
/wrapperMessagingWithoutDetection.js$domain=dagsavisen.no|digi.no|tu.no|vl.no
so this works with no breakages?
@ryanbr Yeah, at least I didn't notice issues.
@ryanbr / @Yuki2718 :
Here are four more sites, which features /wrapperMessagingWithoutDetection.js
:
https://www.friflyt.no/
https://www.friflytbestill.no/
https://www.norsk-klatring.no/
https://www.utemagasinet.no/
@ryanbr / @Yuki2718:
/wrapperMessagingWithoutDetection.js @
dolen.no
driva.no
fjordabladet.no
fjordingen.no
fjt.no
fjuken.no
fosna-folket.no
morenytt.no
nyss.no
rbnett.no
smp.no
vestlandsnytt.no
vigga.no
vikebladet.no
Three more:
jeger.no
landevei.no
terrengsykkel.no
hintaopas.fi
prisjagt.dk
prisjakt.no
prisjakt.nu
--
EDIT: @Yuki2718
@Yuki2718: You awake? :)
I was DoS-ed by notification at the time.
FYI; 'EasyList - Cookie Notices' still lacks /wrapperMessagingWithoutDetection.js
for prisjakt.nu
.
Also, this rule..
hintaopas.fi,ledenicheur.fr,prisjagt.dk,prisjakt.no,prisjakt.nu,pricespy.co.uk,pricespy.co.nz##+js(set-cookie, privacy_settings, 1)
..should be modified to this now:
ledenicheur.fr,pricespy.co.uk,pricespy.co.nz##+js(set-cookie, privacy_settings, 1)
Will do tonight.
There's a new GDPR banner on various Aller Media sites.
https://www.dagbladet.no/
https://www.elbil24.no/
https://www.kk.no/
https://www.seher.no/
https://sol.no/
The banner only appears on first load.
dagbladet.no,elbil24.no,kk.no,seher.no,sol.no###am-branding
Can ###am-branding
be generic?
Probably, but there really aren't that many Aller Media sites, so it would be a bit overkill.
/wrapperMessagingWithoutDetection.js
@ andalsnes-avis.no
/wrapperMessagingWithoutDetection.js
@ kvinneguiden.no
/wrapperMessagingWithoutDetection.js
@ klikk.no
/wrapperMessagingWithoutDetection.js
@ lister24.no
/wrapperMessagingWithoutDetection.js
@ varden.no
/wrapperMessagingWithoutDetection.js
@ aesby.no
There's a cookie popup @ bestdrive.no
.
The Finnish domain (bestdrive.fi
) has it too.
Don't know what would the best approach in this case though.
Issue: Another cookie popup at these domains:
giffits.be
giffits.dk
giffits.es
giffits.fr
giffits.it
giffits.no
giffits.pl
giffits.se
giffits-articles-publicitaires.ch
These domains are already handled by 'EasyList - Cookie Notices':
giffits.de
giffits-werbeartikel.at
giffits-werbeartikel.ch
..whilst 'AdGuard Cookie Notices filter' only handles this domain:
giffits.de
Possible fix:
giffits.*,giffits-articles-publicitaires.ch,giffits-werbeartikel.*##.body__wrapper > div.overlay
giffits.*,giffits-articles-publicitaires.ch,giffits-werbeartikel.*##.cookie_opt_in
There's a cookie popup @
bestdrive.no
. The Finnish domain (bestdrive.fi
) has it too. Don't know what would the best approach in this case though.
https://github.com/uBlockOrigin/uAssets/commit/7eb78d01c29646501ba02d2ec8829487a2575115
@THEtomaso
Now let's wait for EL authors to accept my PR for giffits
domains.
Wow, good work with that BestDrive rule, peace2000! :)
Ooops, missed the PR. But I didn't see cookie popup on giffits-werbeartikel.at
or giffits-werbeartikel.ch
I didn't see cookie popup on
giffits-werbeartikel.at
orgiffits-werbeartikel.ch
Beacause 'EasyList - Cookie Notices' already blocked it at those domains, like I pointed out.
Beacause 'EasyList - Cookie Notices' already blocked it at those domains, like I pointed out.
I overlooked that...
Prerequisites
URL(s) where the issue occurs.
Description
Issue:
New cookie popups at various Norwegian sites.
Possible fix:
/wrapperMessagingWithoutDetection.js$domain=dagsavisen.no|digi.no|tu.no|vl.no
@Yuki2718: Like the ones that you added here: https://github.com/DandelionSprout/adfilt/discussions/932#discussioncomment-8264980 EDIT: ryanbr has added them to 'EasyList - Cookie Notices' now: https://github.com/easylist/easylist/commit/2e095dd68650469ad816276dfb9bd2d1322a8a9a ..but you might wanna add them to 'AdGuard Cookie Notices filter' too, like you've done before.
Note:
Unlike the popups at some Schibsted sites (https://github.com/uBlockOrigin/uAssets/issues/22295/), blocking them with a network rule doesn't appear to break anything, but this might need to be further investigated.
@DandelionSprout: What do you think?
Other extensions used
none
Screenshot(s)
No response
Configuration