uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.21k stars 777 forks source link

scribd.com: ads #22656

Closed andris86 closed 3 days ago

andris86 commented 8 months ago

Prerequisites

URL(s) where the issue occurs.

https://www.scribd.com/document/490608539/Werkstatt-B2-pdf

Description

Ad on the top, ads between document pages, ad on the bottom right corner

Other extensions used

none

Screenshot(s)

Screenshot(s) ![Screenshot 2024-02-25 120615](https://github.com/uBlockOrigin/uAssets/assets/43014154/674a4b40-eed9-438b-8292-976d65277c28) ![Screenshot 2024-02-25 120603](https://github.com/uBlockOrigin/uAssets/assets/43014154/f4f65138-a088-432b-aee5-3ec4bf5e4d32)

Configuration

Details ```yaml uBlock Origin: 1.56.0 Firefox: 123 filterset (summary): network: 241181 cosmetic: 89993 scriptlet: 23694 html: 1784 listset (total-discarded, last-updated): removed: plowe-0: null added: curben-phishing: 116335-34, 24m fanboy-cookiemonster: 50146-191, 21m ublock-cookies-easylist: 988-0, 25m default: user-filters: 1-0, never ublock-filters: 37597-116, 24m ublock-badware: 8006-14, 24m ublock-privacy: 739-0, 24m ublock-unbreak: 2280-2, 24m ublock-quick-fixes: 123-0, 21m Δ easylist: 81761-258, 25m easyprivacy: 50278-50, 25m urlhaus-1: 9145-0, 24m filterset (user): [array of 1 redacted] userSettings: advancedUserEnabled: true hiddenSettings: trustedListPrefixes: ublock- user- supportStats: allReadyAfter: 1085 ms maxAssetCacheWait: 532 ms cacheBackend: indexedDB ```
mapx- commented 8 months ago

it seems to be self promotion

stephenhawk8054 commented 8 months ago

You can add these:

scribd.com##section.body > div[class^="GridContainer-module_wrapper"]:style(padding-top: 0px !important;)
scribd.com##[data-testid="bottom-right-mrec"]
scribd.com##[data-testid="desktop-leaderboard"]
scribd.com##[data-testid="sticky-wrapper"]
scribd.com##.between_page_portal_root
scribd.com##.list_content_wrapper > li:not([data-e2e])
scribd.com##.wrapper__doc_page_shared_recommender_list > a[href]:not([data-e2e])
Yuki2718 commented 8 months ago

Self-promotion is out-of-scope for adblocking filters. Enable either EasyList – Other Annoyances or AdGuard – Other Annoyances. Looks AG decided to address some of them in main list.

Yuki2718 commented 8 months ago

@stephenhawk8054 Are

scribd.com##.list_content_wrapper > li:not([data-e2e])
scribd.com##.wrapper__doc_page_shared_recommender_list > a[href]:not([data-e2e])

on the same page? I don't see them.

Yuki2718 commented 8 months ago

@gorhill The picker is broken only on Chrome.

ghajini commented 8 months ago

also firefox android ubo 1.56

gorhill commented 8 months ago

The picker is broken only on Chrome

Broken how and where?

Yuki2718 commented 8 months ago

Broken how and where?

On the issue URL https://www.scribd.com/document/490608539/Werkstatt-B2-pdf the picker never opens on my end.

gwarser commented 8 months ago

Works fine here.

gorhill commented 8 months ago

Works fine here.

Also can't reproduce, Chromium or Firefox.

Yuki2718 commented 8 months ago

Okay, apparently something in My filters is causing the problem. Cleared My filters after saving its content and readded, the problem was solved. Not directly related, but if I disable My filters, the picker icon disappered. Is this intended?

gorhill commented 8 months ago

if I disable My filters, the picker icon disappered. Is this intended?

Yes: https://github.com/gorhill/uBlock/commit/bc641fc024

ghajini commented 8 months ago

@gorhill i see why it happens, enable ublock annoyances which has this filter scribd.com##+js(aeld, /^(mouseout|mouseleave)$/)

which causes element picker to not act when triggered, is this bug?

Yuki2718 commented 8 months ago

yeah, I can reproduce. Not sure if I had this turend on and disabled on checking filters.

gorhill commented 8 months ago

Still can't reproduce after enabling "uBlock filters -- Annoyances".

D4niloMR commented 8 months ago

@gorhill i see why it happens, enable ublock annoyances which has this filter scribd.com##+js(aeld, /^(mouseout|mouseleave)$/)

which causes element picker to not act when triggered, is this bug?

I can reproduce.

gorhill commented 8 months ago

image

image

image

stephenhawk8054 commented 8 months ago

@stephenhawk8054 Are

scribd.com##.list_content_wrapper > li:not([data-e2e])
scribd.com##.wrapper__doc_page_shared_recommender_list > a[href]:not([data-e2e])

on the same page? I don't see them.

@Yuki2718 It's at the right sidebar where it lists other (related?) file links. At the top and among them when scrolling are the self-promotions.

Yuki2718 commented 8 months ago

It's at the right sidebar where it lists other (related?) file links. At the top and among them when scrolling are the self-promotions.

I see the parent element, but on my end they are always 0 hit for some reason.

stephenhawk8054 commented 3 days ago

https://github.com/uBlockOrigin/uAssets/issues/26046

@Yuki2718 For EL?

scribd.com##.between_page_portal_root
scribd.com###sidebar > div:has([data-e2e^="dismissible-ad-header"])
Yuki2718 commented 3 days ago

Done