uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.12k stars 768 forks source link

myanimelist.net: breakage #22805

Closed nexr4 closed 7 months ago

nexr4 commented 7 months ago

Prerequisites

URL address of the web page

https://myanimelist.net/

Category

breakage

Description

[!NOTE] I feel the need to write this note because the filter list "AdGuard – Ads" isn't checked in the image provided under the "Prerequisites" checklist but the filter list "EasyList" is checked though they are under the same section. So, just in case, I'm assuming the "AdGuard – Ads" filter list is a default one. After all it does come with uBO. But if it isn't a default filter list then please disregard this issue and close it. Thank you for your time.

"AdGuard – Ads" filter list under the "Ads" section visually breaks MyAnimeList.net. I have confirmed this by first disabling uBO. With uBO disabled issue was gone. Then I turned uBO on and disabled all filter lists including my filters and issue was gone. After checking all filter lists individually I saw that it was the filter list "AdGuard – Ads" that caused the breakage. I have confirmed that this is the only filter list that causes the issue. Disabling said filter list fixes the white background issue but it also results in the showing of the color of the background ad (but not the ad itself).

On all screenshots every filter list other than "AdGuard – Ads" is enabled.

First screenshot shows the white background issue on the mainpage of MyAnimeList.net with the filter list "AdGuard – Ads" enabled. ![Screenshot 2024-03-06 234309](https://github.com/uBlockOrigin/uAssets/assets/90934014/b09d8335-8f24-4932-958f-f5eac5966e6b)
Second screenshot shows background color of the ad, but not the ad itself, not filtered by uBO with the filter list "AdGuard – Ads" disabled. ![Screenshot 2024-03-06 235517](https://github.com/uBlockOrigin/uAssets/assets/90934014/6f828757-4382-414d-adac-a824a3ddbe36)
Third screenshot shows the black background being restored on pages without background ads with the filter list disabled. ![Screenshot 2024-03-06 234544](https://github.com/uBlockOrigin/uAssets/assets/90934014/8383567f-06fa-4b39-accf-bb92261ed4a8)

[!NOTE] Here is the first ten lines of the asset ("AdGuard – Ads") that I was talking about:

![Adblock Plus 2.0] ! Checksum: QZ/DWPtHAIuhSOfDraaBdg ! Diff-Path: ../patches/2_without_easylist/2_without_easylist-s-1709750205-3600.patch ! Title: AdGuard Base filter ! Description: This filter is necessary for quality ad blocking. ! Version: 2.3.25.55 ! TimeUpdated: 2024-03-06T18:33:08+00:00 ! Expires: 5 days (update frequency) ! Homepage: https://github.com/AdguardTeam/AdGuardFilters ! License: https://github.com/AdguardTeam/AdguardFilters/blob/master/LICENSE

Other extensions used

Screenshot(s)

Screenshot(s) ![Screenshot 2024-03-06 at 23-33-06 MyAnimeList net - Anime and Manga Database and Community](https://github.com/uBlockOrigin/uAssets/assets/90934014/df3e9881-c6f5-4f92-88a5-9f7b4b690039)

Configuration

```yaml uBlock Origin: 1.56.0 Firefox: 123 filterset (summary): network: 361352 cosmetic: 246267 scriptlet: 49292 html: 1996 listset (total-discarded, last-updated): added: https://secure.fanboy.co.nz/fanboy-annoyance.txt: 79948-79942, 5m adguard-generic: 79051-809, never adguard-mobile: 9112-20, 3m adguard-spyware-url: 1470-106, 3m adguard-spyware: 113737-33582, 3m block-lan: 61-0, 3m curben-phishing: 116116-43, 4m adguard-social: 22213-864, 4m adguard-cookies: 28884-72, 4m ublock-cookies-adguard: 1018-0, 4m adguard-popup-overlays: 26734-1631, 4m adguard-mobile-app-banners: 5062-1083, 4m [12 lists not shown]: [too many] default: user-filters: 12-0, never ublock-filters: 37398-3691, 3m ublock-badware: 7760-14, 3m ublock-privacy: 739-0, 3m ublock-unbreak: 2293-1, 3m ublock-quick-fixes: 153-1, 3m easylist: 81722-2264, 3m easyprivacy: 50333-1205, 3m urlhaus-1: 7405-5, 4m plowe-0: 3779-84, 4m filterset (user): [array of 12 redacted] trustedset: added: [array of 2 redacted] switchRuleset: added: [array of 1 redacted] userSettings: cloudStorageEnabled: true hiddenSettings: [none] supportStats: allReadyAfter: 16963 ms (selfie) maxAssetCacheWait: 7148 ms cacheBackend: indexedDB popupPanel: blocked: 9 network: myanimelist.net: 2 google-analytics.com: 1 googlesyndication.com: 1 googletagmanager.com: 1 googletagservices.com: 1 quantcast.com: 1 unblockia.com: 2 extended: ##.footer-app ##.header-mini-banner ##.btn-mal-service ##.footer-social-media ##[src*="/c/img/images/event/"] ##.grecaptcha-badge ##body:style(background-color: inherit!important;) ##+js(nofab) ##+js(set-local-storage-item, wf-promo-2::d, 1) ##+js(set-constant, rwt, noopFunc) ##+js(trusted-set-cookie, SOCS, CAESHAgBEhJnd3NfMjAyMzA2MTItMF9S… ##+js(remove-attr, ping, div[id="search"] a[data-ved][ping]) ```
D4niloMR commented 7 months ago

Caused by myanimelist.net#$#body { background-color: inherit!important; }

@Alex-302

D4niloMR commented 7 months ago

Maybe?

myanimelist.net##+js(rmnt, style, /body:not\(.ownlist\) {\s+background-color: #E3EEFF;\s+background-image: url\(data:image\/png;base64/)
Alex-302 commented 7 months ago

That rule was removed. https://github.com/AdguardTeam/AdguardFilters/commit/8fb3fe2dd6b9607e8f80ade6330fcc5c2f62f617